Enhance docs for dual-stack migration and add validation for update of ipFamilies. #12523
Conversation
|
@axel7born: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/area documentation |
|
/kind enhancement |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScheererJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if !apiequality.Semantic.DeepEqual(newIPFamilies, oldIPFamilies) { | ||
| allErrs = append(allErrs, field.Forbidden(fldPath, | ||
| fmt.Sprintf("unsupported IP family update: oldIPFamilies=%v, newIPFamilies=%v", oldIPFamilies, newIPFamilies))) | ||
| } |
There was a problem hiding this comment.
This will not allow migration from ipv6 to [ipv6, ipv4], the docs suggest this should be supported scenario
* Update docs. * Update validation.
2f49ef5 to
6aec507
Compare
| @@ -17,7 +17,9 @@ Dual-stack networking allows clusters to operate with both IPv4 and IPv6 protoco | |||
|
|
|||
| ### Key Considerations | |||
|
|
|||
| - Adding a new protocol is only allowed as the second element in the array, ensuring the primary protocol remains unchanged. | |||
| - Single stack IPv4 clusters can be migrated to dual-stack by adding IPv6 as second element. | |||
| -The migration of single stack IPv6 clusters to dual-stack is not supported. | |||
There was a problem hiding this comment.
Haven't tracked the topic, but is it really not supported?
| -The migration of single stack IPv6 clusters to dual-stack is not supported. | |
| - The migration of single stack IPv6 clusters to dual-stack is not supported. |
There was a problem hiding this comment.
We planned to support it as we thought it would not be much additional effort. However, we abandoned the idea as we didn't see a real use case.
| @@ -1164,7 +1164,7 @@ type Networking struct { | |||
| Nodes *string | |||
| // Services is the CIDR of the service network. This field is immutable. | |||
| Services *string | |||
| // IPFamilies specifies the IP protocol versions to use for shoot networking. This field is immutable. | |||
| // IPFamilies specifies the IP protocol versions to use for shoot networking. | |||
There was a problem hiding this comment.
Same change is needed at
gardener/pkg/apis/core/v1beta1/types_shoot.go
Line 1534 in c56c935
e51ce73 to
d6c6ac4
Compare
|
LGTM label has been added. Git tree hash: a4947868693875b851ee6a515f7f495bd07aee38
|
How to categorize this PR?
/area documentation
/kind enhancement
What this PR does / why we need it:
Emphasize that migration to dual-stack can't be reverted.
Add validation for updates to spec.networking.ipFamilies.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: