Add VPA maxAllowed field to the Shoot, Seed and Garden resources #12481
Conversation
|
Skipping CI for Draft Pull Request. |
9e593ab to
54695de
Compare
13e8362 to
995e015
Compare
|
FYI @tobschli @dergeberl |
|
/assign |
|
/assign |
|
/assign @vitanovs |
|
I start the rebase now. Wish me luck 🤞 |
There was a problem hiding this comment.
Thanks for the comprehensive PR and the well structured commit history, it definitely helped a lot while reviewing!
Tested the change locally with a resource-consumer deployment, everything sets up correctly and the vpa-recommender gets deployed with both ( or one, depending on the config ) additional container arguments.
/lgtm
e65fbf6 to
fed9587
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov, vitanovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: c58b31a10d6239720cb40e702c40e6e573ff6a23
|
|
/test pull-gardener-e2e-kind-gardenadm |
How to categorize this PR?
/area auto-scaling
/kind enhancement
What this PR does / why we need it:
The vpa-recommender has the following known limitation:
In order to address this limitation, the following enhancement was contributed to the upstream: kubernetes/autoscaler#7560. It allows to globally (on vpa-recommdender level) cap the maximum allowed recommendation the vpa-recommender can recommend for a container. In this way, the vpa-recommender can be made aware of the cluster limits by configuring the global maximum allowed to the largest Node's allocatable. Fore more details, see the Specifying global maximum allowed resources to prevent pods from being unschedulable.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
This PR is resolves the Prevent Pod Scheduling Issues Due To Overscaling topic from the Gardener Hackathon 12/2024.
An old PR which tried to solve the same problem but the implementation proposal got rejected: #10413
Release note:
The Shoot resource does now support configuring the global maximum allowed resources the vpa-recommender can recommend for a container. The corresponding upstream configuration option solves a known limitation of vpa-recommender where it can make a Pod unschedulable by recommending resource requests more than largest Node's allocatable. For more details, see [Specifying global maximum allowed resources to prevent pods from being unschedulable](https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/docs/examples.md#specifying-global-maximum-allowed-resources-to-prevent-pods-from-being-unschedulable).The Seed and Garden resources do now support configuring the global maximum allowed resources the vpa-recommender can recommend for a container. The corresponding upstream configuration option solves a known limitation of vpa-recommender where it can make a Pod unschedulable by recommending resource requests more than largest Node's allocatable. For more details, see [Specifying global maximum allowed resources to prevent pods from being unschedulable](https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/docs/examples.md#specifying-global-maximum-allowed-resources-to-prevent-pods-from-being-unschedulable).