Skip to content

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Jul 7, 2025

How to categorize this PR?

/area ipcei
/kind enhancement

What this PR does / why we need it:
In preparation for gardenadm connect, this PR introduces a new scenario for make gardenadm-up. It deploys gardener-operator and a Garden resource (which brings up a Gardener). This Gardener deployment can be later used to connect autonomous shoot clusters to.

Which issue(s) this PR fixes:
Part of #2906

Special notes for your reviewer:
/cc @ScheererJ

The virtual cluster is currently not accessible because make kind-up does not map the needed ports to the host machine. Eventually, this will resolve automatically once progress on #11958 continues.

Nevertheless, a component running inside the machine pods (i.e., inside the automous shoot cluster) should still be able to communicate to the virtual cluster (via cluster-internal communication).

Release note:

NONE

@gardener-prow gardener-prow bot requested a review from ScheererJ July 7, 2025 10:18
@gardener-prow gardener-prow bot added area/ipcei IPCEI (Important Project of Common European Interest) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2025
@ScheererJ
Copy link
Member

/assign

Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the next increment towards GEP-28. This makes it look easy to add the Garden to the gardenadm setup :-) .

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
Copy link
Contributor

gardener-prow bot commented Jul 7, 2025

LGTM label has been added.

Git tree hash: 34829c1b9d89d5262e6a01de103200bb6b04e032

Copy link
Contributor

gardener-prow bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
rfranzke added 3 commits July 7, 2025 16:58
The virtual cluster is currently not accessible because `make kind-up`
does not map the needed ports to the host machine. Eventually, this will
resolve automatically once progress on gardener#11958
continues.

Nevertheless, a component running inside the machine pods (i.e., inside
the automous shoot cluster) should still be able to communicate to the
virtual cluster (via cluster-internal communication).
@rfranzke rfranzke force-pushed the gep28/gardener-local branch from 482fa27 to eec8687 Compare July 7, 2025 14:58
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@gardener-prow gardener-prow bot requested a review from ScheererJ July 7, 2025 14:58
@ScheererJ
Copy link
Member

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
Copy link
Contributor

gardener-prow bot commented Jul 7, 2025

LGTM label has been added.

Git tree hash: 0cd2f683eea0ca0cbbe6efa4a13cc3e62c17d188

@gardener-prow gardener-prow bot merged commit d14dd1e into gardener:master Jul 7, 2025
19 checks passed
@rfranzke rfranzke deleted the gep28/gardener-local branch July 8, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants