Skip to content

Set constraint to progressing to prevent it from being displayed as error in the dashboard. #12470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Set constraint to progressing to prevent it from being displayed as error in the dashboard. #12470

merged 1 commit into from
Jul 9, 2025

Conversation

axel7born
Copy link
Contributor

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
The constraint DualStackNodesMigrationReady is used to track, if the nodes in the shoot are prepared for a migration of the shoot to dual-stack networking. However, a constraint with status false is displayed as error in the gardener dashboard. As this is confusing users, we change the constraint status to progressing which will be displayed in the dashboard with gardener/dashboard#2503.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The status of constraint  `DualStackNodesMigrationReady`  is now `progressing` instead of `false` at the start of a migration to dual-stack networking.

@gardener-prow gardener-prow bot added the area/networking Networking related label Jul 7, 2025
@gardener-prow gardener-prow bot requested a review from Kostov6 July 7, 2025 09:44
@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Jul 7, 2025
@gardener-prow gardener-prow bot requested a review from shafeeqes July 7, 2025 09:44
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2025
@axel7born
Copy link
Contributor Author

/cc @DockToFuture @ScheererJ @grolu

@gardener-prow gardener-prow bot requested review from DockToFuture and ScheererJ July 7, 2025 09:45
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jul 7, 2025

@axel7born: GitHub didn't allow me to request PR reviews from the following users: grolu.

Note that only gardener members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @DockToFuture @ScheererJ @grolu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ScheererJ
ScheererJ approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Thanks for improving the usability of the dual-stack migration.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jul 7, 2025

LGTM label has been added.

Git tree hash: 3bee3a57afa020f4eaee89c9033a0f4a7378b67e

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@axel7born
Set constraint to progressing to prevent it from
5ab8090 
being displayed as error in the dashboard.
@axel7born axel7born force-pushed the enh/node-constraint-progessing branch from 9d5c1c0 to 5ab8090 Compare July 7, 2025 13:27
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@gardener-prow gardener-prow bot requested a review from ScheererJ July 7, 2025 13:27
@rfranzke
Copy link
Member

rfranzke commented Jul 8, 2025

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jul 8, 2025

LGTM label has been added.

Git tree hash: a398e5a24570fbedd5a0102c11f1cec4c149fb66

@gardener-prow gardener-prow bot merged commit ba03c89 into gardener:master Jul 9, 2025
19 checks passed
@axel7born axel7born mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kostov6 Kostov6 Awaiting requested review from Kostov6

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

@DockToFuture DockToFuture Awaiting requested review from DockToFuture

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

Assignees

@rfranzke rfranzke

@ScheererJ ScheererJ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking Networking related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axel7born @rfranzke @ScheererJ