Skip to content

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Jul 2, 2025

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:
This PR introduces the target Makefile rules proposed in #11958:

  • make operator-up to deploy the gardener-operator
  • make garden-up to create the Garden resource
  • make seed-up to create the Gardenlet resource (deployment of gardenlet via gardener-operator)
  • make gardenadm-up with SCENARIO environment variable that can be set to high-touch or medium-touch (default: high-touch)

The respective scenario (multi-zone/multi-node/multi-node2 is auto-detected based on the targeted kind cluster).

For backwards-compatibiltiy, make operator-seed-up is still there, but the plan is to rename it to make gardener-up once the legacy Helm chart-based setup has been refactored.

Secondly, based on the work in #12138, we now have make kind-single-node-{up,down} which deploys a single-node kind cluster with gardener-operator. Using make garden-up seed-up, it is possible to create a Garden and a Seed in it.

Which issue(s) this PR fixes:
Part of #11958

Special notes for your reviewer:
/cc @ScheererJ @oliver-goetz

Release note:

NONE

@gardener-prow gardener-prow bot requested review from oliver-goetz and ScheererJ July 2, 2025 12:21
@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 2, 2025
@rfranzke rfranzke force-pushed the devsetup-targets branch 2 times, most recently from c8b7cf5 to 1926d41 Compare July 2, 2025 13:10
@rfranzke rfranzke changed the title make {operator,garden,seed,gardenadm}-{up,dev,debug,down} make {operator,garden,seed,gardenadm}-{up,dev,debug,down}, support single-node kind cluster w/ gardener-operator Jul 2, 2025
Copy link
Member

@LucaBernstein LucaBernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
Copy link
Contributor

gardener-prow bot commented Jul 3, 2025

LGTM label has been added.

Git tree hash: ba3b2f985a4dc121341f8085af10627b71210059

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2025
@rfranzke rfranzke force-pushed the devsetup-targets branch from d7863ef to e6add51 Compare July 3, 2025 15:16
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
@gardener-prow gardener-prow bot requested a review from LucaBernstein July 3, 2025 15:16
@rfranzke rfranzke force-pushed the devsetup-targets branch from e6add51 to 73c5511 Compare July 3, 2025 15:17
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2025
@oliver-goetz
Copy link
Member

So many make and bash changes, crazy 😜

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2025
Copy link
Contributor

gardener-prow bot commented Jul 4, 2025

LGTM label has been added.

Git tree hash: 1ecdfce809291f7c39621741da57ef32fd3015f3

@rfranzke
Copy link
Member Author

rfranzke commented Jul 7, 2025

/approve

Copy link
Contributor

gardener-prow bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@gardener-prow gardener-prow bot merged commit 378796b into gardener:master Jul 7, 2025
22 checks passed
@rfranzke rfranzke deleted the devsetup-targets branch July 7, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants