Skip to content

[GEP-28]: Support Extension.operator.gardener.cloud in gardenadm #12427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2025
Merged

[GEP-28]: Support Extension.operator.gardener.cloud in gardenadm #12427

merged 3 commits into from
Jul 1, 2025

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area ipcei
/kind enhancement

What this PR does / why we need it:

With this PR, gardenadm supports Extension.operator.gardener.cloud manifests when reading --config-dir in addition to Controller{Registration,Deployment}.core.gardener.cloud.
Extension.operator.gardener.cloud is the new standard way of managing extensions, so gardenadm should support it as a first-class citizen.
In the gardenadm local setup, provider-local is now deployed via an Extension.

Which issue(s) this PR fixes:
Part of #2906

Special notes for your reviewer:

/cc @ScheererJ @rfranzke @maboehm

Release note:

NONE

@gardener-prow gardener-prow bot requested a review from ScheererJ June 30, 2025 15:15
@gardener-prow gardener-prow bot added the area/ipcei IPCEI (Important Project of Common European Interest) label Jun 30, 2025
@gardener-prow gardener-prow bot requested a review from rfranzke June 30, 2025 15:15
@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Jun 30, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jun 30, 2025

@timebertt: GitHub didn't allow me to request PR reviews from the following users: maboehm.

Note that only gardener members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

How to categorize this PR?

/area ipcei
/kind enhancement

What this PR does / why we need it:

With this PR, gardenadm supports Extension.operator.gardener.cloud manifests when reading --config-dir in addition to Controller{Registration,Deployment}.core.gardener.cloud.
Extension.operator.gardener.cloud is the new standard way of managing extensions, so gardenadm should support it as a first-class citizen.
In the gardenadm local setup, provider-local is now deployed via an Extension.

Which issue(s) this PR fixes:
Part of #2906

Special notes for your reviewer:

/cc @ScheererJ @rfranzke @maboehm

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 30, 2025
@timebertt timebertt mentioned this pull request Jun 30, 2025
Open
rfranzke
rfranzke reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jul 1, 2025

LGTM label has been added.

Git tree hash: 1a359cde0401c8c1995451e5dc2e739affcd6aed

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025
@gardener-prow gardener-prow bot merged commit 3e66879 into gardener:master Jul 1, 2025
19 checks passed
@timebertt timebertt deleted the gardenadm-extension branch July 1, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timebertt @rfranzke