Skip to content

[GEP-28] Logging Infrastructure #11390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 17, 2025
Merged

[GEP-28] Logging Infrastructure #11390

merged 5 commits into from
Feb 17, 2025

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area ipcei
/kind enhancement

What this PR does / why we need it:
Prepare logging infrastructure for gardenadm commands

Which issue(s) this PR fixes:
Part of #2906

Special notes for your reviewer:
/cc @ScheererJ @timebertt

Release note:

NONE

@gardener-prow gardener-prow bot added area/ipcei IPCEI (Important Project of Common European Interest) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2025
@rfranzke rfranzke mentioned this pull request Feb 14, 2025
Open
@rfranzke rfranzke force-pushed the gep28/logging branch 3 times, most recently from 9c1ac82 to 9a2a84b Compare February 14, 2025 09:50
timebertt
timebertt reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR :)

@timebertt timebertt self-assigned this Feb 14, 2025
@gardener-prow gardener-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2025
@rfranzke rfranzke force-pushed the gep28/logging branch 2 times, most recently from 2e8d3eb to 357455d Compare February 14, 2025 11:11
@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Feb 14, 2025
@ScheererJ
Copy link
Member

/assign

timebertt
timebertt reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks!
One nit only

ScheererJ
ScheererJ reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for providing the means to log in the gardenadm commands. It looks good already.

timebertt
timebertt approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 17, 2025

LGTM label has been added.

Git tree hash: 9d1aef6fe4068bcb48a341be81f44e837dad481a

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2025
timebertt
timebertt reviewed Feb 17, 2025
View reviewed changes
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@gardener-prow gardener-prow bot requested a review from timebertt February 17, 2025 08:01
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 17, 2025

LGTM label has been added.

Git tree hash: 98378b69030d0857060b25e828e308a9ce11e541

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rfranzke rfranzke requested a review from timebertt February 17, 2025 08:04
@gardener-prow gardener-prow bot merged commit fcac648 into gardener:master Feb 17, 2025
19 checks passed
@rfranzke rfranzke deleted the gep28/logging branch February 17, 2025 14:03
@timebertt timebertt mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

@timebertt timebertt Awaiting requested review from timebertt

Assignees

@ScheererJ ScheererJ

@timebertt timebertt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfranzke @ScheererJ @timebertt