[GEP-28] Prepare gardener/resourcemanager component for "bootstrap control plane" case
#11343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign |
ScheererJ
reviewed
Feb 11, 2025
|
LGTM label has been added. Git tree hash: 47d83a6376d91341d62c5213647a638b6e10ff02
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScheererJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- set hostNetwork=true - tolerate all taints - set API server address to 127.0.0.1
For better distinction which features are enabled. This is a prefactoring step because we'll introduce a third mode `ForSourceAndTarget`.
- enable certain webhooks
Instead of providing many arguments in the functions, just pass the values that should be overridden with whatever user-desired config, and apply them to the default values of the respective function.
be64797 to
fd5fdea
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 1210dec087e95d1aad473cb431c8abc2eab45902
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area ipcei
/kind enhancement
What this PR does / why we need it:
This PR augments the
gardener/resourcemanagercomponent as follows:BootstrapControlPlaneis introduced in theValueswhichhostNetwork=true127.0.0.1TargetDiffersFromSourceClusterfield is replaced withResponsibilityModewhich can beForSource,ForTarget, or (new scenario)ForSourceAndTargetForSourceAndTarget, certain webhooks are enabled that usually only run in the "responsible for shoot" modeOn the way, I improved the instantiation of a new GRM component via the
component/sharedpackage.Which issue(s) this PR fixes:
Part of #2906
Special notes for your reviewer:
/cc @ScheererJ
Release note: