Skip to content

Allow configuring a maximum node count per shoot #11279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 12, 2025
Merged

Allow configuring a maximum node count per shoot #11279

merged 11 commits into from
Feb 12, 2025

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area usability robustness
/kind enhancement

What this PR does / why we need it:

This PR introduces a new feature for operators to configure a maximum number of nodes that is support in a Gardener installation.
See the linked issue for the motivation and the documentation in the first commit for how it works.

Which issue(s) this PR fixes:
Fixes #11196

Special notes for your reviewer:

Release note:

`CloudProfile.spec.limits.maxNodesTotal` can be used to limit the maximum number of nodes a shoot can have during runtime. See [the documentation](https://github.com/gardener/gardener/blob/master/docs/usage/shoot/shoot_limits.md) for more details.

@gardener-prow gardener-prow bot added area/usability Usability related area/robustness Robustness, reliability, resilience related labels Feb 3, 2025
@gardener-prow gardener-prow bot requested review from ScheererJ and tobschli February 3, 2025 15:06
@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 3, 2025
@timuthy
Copy link
Member

timuthy commented Feb 4, 2025

/assign

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2025
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2025
maboehm
maboehm reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@maboehm maboehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some small comments, otherwise lgtm

@maboehm maboehm mentioned this pull request Feb 7, 2025
Merged
rfranzke
rfranzke reviewed Feb 7, 2025
View reviewed changes
@timebertt
Copy link
Member Author

@rfranzke @maboehm PTAL :)

rfranzke
rfranzke reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 10, 2025

LGTM label has been added.

Git tree hash: c02ba456ea983391d3295e8408ffb50f71ae0524

@maboehm
Copy link
Contributor

maboehm commented Feb 10, 2025

lgtm too :)

@timebertt
Copy link
Member Author

@timuthy do you still plan on having a look or should we go ahead with this PR? :)

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2025
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@gardener-prow gardener-prow bot requested review from rfranzke and timuthy February 11, 2025 06:53
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2025
@timebertt
Copy link
Member Author

/retest

timuthy
timuthy reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more findings from my side. Thanks for the contribution 🙂

timuthy
timuthy reviewed Feb 12, 2025
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 12, 2025

LGTM label has been added.

Git tree hash: 005d0a7e8f8a274eedc6c9e70495860aa11cb79c

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timuthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@gardener-prow gardener-prow bot merged commit a727da2 into gardener:master Feb 12, 2025
19 checks passed
@timebertt timebertt deleted the max-node-count branch February 12, 2025 16:21
@Duciwuci Duciwuci mentioned this pull request Feb 25, 2025
Merged
@LucaBernstein LucaBernstein mentioned this pull request Mar 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timuthy timuthy timuthy left review comments

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

@tobschli tobschli Awaiting requested review from tobschli

@rfranzke rfranzke Awaiting requested review from rfranzke

+1 more reviewer

@maboehm maboehm maboehm left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@rfranzke rfranzke

@timuthy timuthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/robustness Robustness, reliability, resilience related area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuring a maximum node count per shoot
4 participants
@timebertt @timuthy @maboehm @rfranzke