Drop internal version of extensions/pkg/apis/config API
#11056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
/test all |
|
/retest |
|
LGTM label has been added. Git tree hash: 596b90ccb28e10d9ecb6d042d9e58cdbca0a09c1
|
299573c to
e56d5af
Compare
marc1404
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
/lgtm
/approve
From the PR description: It was probably meant to say that we're only using the external version, right?
This PR drops the internal version of the extensions/pkg/apis/config API.
There wasn't even any conversion code and we only used theinternalexternal version.
|
LGTM label has been added. Git tree hash: 1f6c42ac583d77c2e06295774e92d1d29301f65d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marc1404 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
We always used the internal version before this change. From now on, there is only the external version and we switch all usages to the external version. |
ialidzhikov
added a commit
to ialidzhikov/gardener
that referenced
this pull request
Jul 29, 2025
`github.com/gardener/gardener/extensions/pkg/apis/config` was removed with gardener#11056.
gardener-prow bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
* Clean up exclusion of non-existing `pkg/client/extensions` path Extension clients are no longer generated after #4592. * Clean up exclusion of non-existing `builtin$` path I don't find in the project a path matching `builtin$`. * Clean up exclusion of non-existing `examples$` path I don't find in the project a path matching `examples$`. We have a dir named `example/`, not `examples/`. * Update fluent-operator import alias With #11673, the fluent-operator imports were updated from `github.com/fluent/fluent-operator/v2` to `github.com/fluent/fluent-operator/v3`. * Clean up import alias for non-existing pkg `github.com/gardener/gardener/extensions/pkg/apis/config` was removed with #11056. * Clean up import alias for non-existing pkg(s) Internal component config APIs were removed. See #11043 * Add `pkg/client/security` to the list of excluded dirs `pkg/client/security` contains generated clientset, informers and listers. Similar to the other generated dirs, it should be excluded. * Update the import alias for etcd-druid crds pkg Introduced with #11545. The correct pkg is `github.com/gardener/etcd-druid/api/core/v1alpha1/crds`, not `github.com/gardener/etcd-druid/api/core/crds`. * Clean up paths with generated code from `linters.exclusions.paths` We already use `linters.exclusions.generated=lax`. `lax` mode should automatically detect and ignore generated files. Ref https://golangci-lint.run/usage/configuration/#linters-configuration * Clean up the exclusion of the `third_party` path In the Makefile, we explicitly pass the paths to be checked. `third_party` is not among them. Hence, there is no need to exclude it as we don't check for it. https://github.com/gardener/gardener/blob/v1.124.0/Makefile#L165 * Don't check for imports under `third_party` `third_party` currently contains a forked dependency and generated mocks. Hence, I don't see much value for checking for imports there as it does not contain a pkg which is not generated or not copied. * Address PR review feedback from dimitar-kostadinov
Duciwuci
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Sep 1, 2025
* Clean up exclusion of non-existing `pkg/client/extensions` path Extension clients are no longer generated after gardener#4592. * Clean up exclusion of non-existing `builtin$` path I don't find in the project a path matching `builtin$`. * Clean up exclusion of non-existing `examples$` path I don't find in the project a path matching `examples$`. We have a dir named `example/`, not `examples/`. * Update fluent-operator import alias With gardener#11673, the fluent-operator imports were updated from `github.com/fluent/fluent-operator/v2` to `github.com/fluent/fluent-operator/v3`. * Clean up import alias for non-existing pkg `github.com/gardener/gardener/extensions/pkg/apis/config` was removed with gardener#11056. * Clean up import alias for non-existing pkg(s) Internal component config APIs were removed. See gardener#11043 * Add `pkg/client/security` to the list of excluded dirs `pkg/client/security` contains generated clientset, informers and listers. Similar to the other generated dirs, it should be excluded. * Update the import alias for etcd-druid crds pkg Introduced with gardener#11545. The correct pkg is `github.com/gardener/etcd-druid/api/core/v1alpha1/crds`, not `github.com/gardener/etcd-druid/api/core/crds`. * Clean up paths with generated code from `linters.exclusions.paths` We already use `linters.exclusions.generated=lax`. `lax` mode should automatically detect and ignore generated files. Ref https://golangci-lint.run/usage/configuration/#linters-configuration * Clean up the exclusion of the `third_party` path In the Makefile, we explicitly pass the paths to be checked. `third_party` is not among them. Hence, there is no need to exclude it as we don't check for it. https://github.com/gardener/gardener/blob/v1.124.0/Makefile#L165 * Don't check for imports under `third_party` `third_party` currently contains a forked dependency and generated mocks. Hence, I don't see much value for checking for imports there as it does not contain a pkg which is not generated or not copied. * Address PR review feedback from dimitar-kostadinov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind cleanup
What this PR does / why we need it:
This PR drops the internal version of the
extensions/pkg/apis/configAPI.There wasn't even any conversion code and we only used the internal version. So get rid of the duplication to prevent confusion and reduce development/maintenance efforts.
Which issue(s) this PR fixes:
Part of #11043
Special notes for your reviewer:
Release note: