Skip to content

Conversation

acumino
Copy link
Member

@acumino acumino commented May 2, 2025

How to categorize this PR?

/area test delivery open-source scalability
/kind enhancement

What this PR does / why we need it:
This PR adds TM test for the worker pools with InPlace update strategy, the test verifies that after performing update the nodes should remain the same.

Which issue(s) this PR fixes:
Part of #10219

Special notes for your reviewer:

Release note:

NONE

Copy link
Contributor

gardener-prow bot commented May 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/delivery Delivery related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/scalability Scalability related kind/enhancement Enhancement, improvement, extension labels May 2, 2025
Copy link
Contributor

gardener-prow bot commented May 2, 2025

@acumino: The label(s) area/test cannot be applied, because the repository doesn't have them.

In response to this:

How to categorize this PR?

/area test delivery open-source scalability
/kind enhancement

What this PR does / why we need it:
This PR adds TM test for the worker pools with InPlace update strategy, the test verifies that after performing update the nodes should remain the same.

Which issue(s) this PR fixes:
Part of #10219

Special notes for your reviewer:

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label May 2, 2025
@gardener-prow gardener-prow bot requested review from ScheererJ and tobschli May 2, 2025 07:41
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 2, 2025
@acumino
Copy link
Member Author

acumino commented May 2, 2025

/test all

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2025
@acumino acumino force-pushed the inplace-updates-tm-tests branch from cd880a4 to b6a464c Compare May 12, 2025 10:17
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2025
@acumino
Copy link
Member Author

acumino commented May 12, 2025

/test all

@acumino acumino marked this pull request as ready for review May 12, 2025 10:18
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2025
@gardener-prow gardener-prow bot requested review from ary1992 and oliver-goetz May 12, 2025 10:18
@acumino acumino force-pushed the inplace-updates-tm-tests branch from b6a464c to d63b3ed Compare May 12, 2025 11:52
@acumino acumino changed the title Add TM test for worker pools with InPlace update strategy [GEP-31] Add TM test for worker pools with InPlace update strategy May 12, 2025
Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general.

@acumino acumino force-pushed the inplace-updates-tm-tests branch from d63b3ed to 9aded8f Compare May 13, 2025 08:54
@acumino acumino requested a review from shafeeqes May 13, 2025 08:54
@acumino acumino force-pushed the inplace-updates-tm-tests branch from 9aded8f to 30d1bc6 Compare May 13, 2025 12:15
Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

Copy link
Contributor

gardener-prow bot commented May 13, 2025

LGTM label has been added.

Git tree hash: 2aab017442e1d027f736fdd0550c7b4d302dacc5

Copy link
Contributor

gardener-prow bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke, shafeeqes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shafeeqes
Copy link
Contributor

/retest

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@shafeeqes
Copy link
Contributor

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
Copy link
Contributor

gardener-prow bot commented May 14, 2025

LGTM label has been added.

Git tree hash: 8ca2b94f3c317eb3c4df824725f38df4ff186f40

@shafeeqes shafeeqes force-pushed the inplace-updates-tm-tests branch from 52149da to 1cbd2aa Compare May 14, 2025 05:03
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@shafeeqes
Copy link
Contributor

Pushed 1cbd2aa, similar to 20f8dac

@shafeeqes
Copy link
Contributor

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
Copy link
Contributor

gardener-prow bot commented May 14, 2025

LGTM label has been added.

Git tree hash: 4b336ab7adcf88afde808f75941e5133cbabdb30

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@shafeeqes
Copy link
Contributor

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
Copy link
Contributor

gardener-prow bot commented May 14, 2025

LGTM label has been added.

Git tree hash: 14e4ee20b6727ac9c6cbb6e0db47417987a18875

@gardener-prow gardener-prow bot merged commit cff94f7 into gardener:master May 14, 2025
19 checks passed
@shafeeqes shafeeqes deleted the inplace-updates-tm-tests branch May 14, 2025 10:29
shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jun 3, 2025
This was wrongly replaced in gardener#11990
shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jun 3, 2025
This was wrongly replaced in gardener#11990
gardener-prow bot pushed a commit that referenced this pull request Jun 3, 2025
…12241)

* Use correct lastInitationTime during credentials rotation without workers rollout

* Use correct function in e2e test

This was wrongly replaced in #11990

* Add e2e tests for in-place and without-workers-rollout combination

* Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated
gardener-prow bot pushed a commit that referenced this pull request Jun 3, 2025
… in-place update (#12249)

* Use correct lastInitationTime during credentials rotation without workers rollout

* Use correct function in e2e test

This was wrongly replaced in #11990

* Add e2e tests for in-place and without-workers-rollout combination

* Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated

---------

Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com>
ary1992 pushed a commit to ary1992/gardener that referenced this pull request Jun 4, 2025
gardener-prow bot pushed a commit that referenced this pull request Jun 4, 2025
… in-place update (#12254)

* Use correct lastInitationTime during credentials rotation without workers rollout

* Use correct function in e2e test

This was wrongly replaced in #11990

* Add e2e tests for in-place and without-workers-rollout combination

* Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated

---------

Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com>
Wieneo pushed a commit to stackitcloud/gardener that referenced this pull request Jun 6, 2025
… in-place update (gardener#12249)

* Use correct lastInitationTime during credentials rotation without workers rollout

* Use correct function in e2e test

This was wrongly replaced in gardener#11990

* Add e2e tests for in-place and without-workers-rollout combination

* Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated

---------

Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com>
ske-prow bot pushed a commit to stackitcloud/gardener that referenced this pull request Jun 6, 2025
* [release-v1.120] Fix credentials rotation without workers rollout for in-place update (gardener#12249)

* Use correct lastInitationTime during credentials rotation without workers rollout

* Use correct function in e2e test

This was wrongly replaced in gardener#11990

* Add e2e tests for in-place and without-workers-rollout combination

* Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated

---------

Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com>

* Release v1.120.1

---------

Co-authored-by: Gardener Prow Robot <gardener.ci.robot@gmail.com>
Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com>
Co-authored-by: gardener-robot-ci-2 <gardener.ci.user2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/delivery Delivery related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/scalability Scalability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants