-
Notifications
You must be signed in to change notification settings - Fork 527
[GEP-31] Add TM test for worker pools with InPlace update strategy #11990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEP-31] Add TM test for worker pools with InPlace update strategy #11990
Conversation
Skipping CI for Draft Pull Request. |
@acumino: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test all |
cd880a4
to
b6a464c
Compare
/test all |
b6a464c
to
d63b3ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
d63b3ed
to
9aded8f
Compare
9aded8f
to
30d1bc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
LGTM label has been added. Git tree hash: 2aab017442e1d027f736fdd0550c7b4d302dacc5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke, shafeeqes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
LGTM label has been added. Git tree hash: 8ca2b94f3c317eb3c4df824725f38df4ff186f40
|
52149da
to
1cbd2aa
Compare
/lgtm |
LGTM label has been added. Git tree hash: 4b336ab7adcf88afde808f75941e5133cbabdb30
|
/lgtm |
LGTM label has been added. Git tree hash: 14e4ee20b6727ac9c6cbb6e0db47417987a18875
|
This was wrongly replaced in gardener#11990
This was wrongly replaced in gardener#11990
…12241) * Use correct lastInitationTime during credentials rotation without workers rollout * Use correct function in e2e test This was wrongly replaced in #11990 * Add e2e tests for in-place and without-workers-rollout combination * Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated
… in-place update (#12249) * Use correct lastInitationTime during credentials rotation without workers rollout * Use correct function in e2e test This was wrongly replaced in #11990 * Add e2e tests for in-place and without-workers-rollout combination * Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated --------- Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com>
This was wrongly replaced in gardener#11990
… in-place update (#12254) * Use correct lastInitationTime during credentials rotation without workers rollout * Use correct function in e2e test This was wrongly replaced in #11990 * Add e2e tests for in-place and without-workers-rollout combination * Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated --------- Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com>
… in-place update (gardener#12249) * Use correct lastInitationTime during credentials rotation without workers rollout * Use correct function in e2e test This was wrongly replaced in gardener#11990 * Add e2e tests for in-place and without-workers-rollout combination * Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated --------- Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com>
* [release-v1.120] Fix credentials rotation without workers rollout for in-place update (gardener#12249) * Use correct lastInitationTime during credentials rotation without workers rollout * Use correct function in e2e test This was wrongly replaced in gardener#11990 * Add e2e tests for in-place and without-workers-rollout combination * Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated --------- Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com> * Release v1.120.1 --------- Co-authored-by: Gardener Prow Robot <gardener.ci.robot@gmail.com> Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com> Co-authored-by: gardener-robot-ci-2 <gardener.ci.user2@gmail.com>
How to categorize this PR?
/area test delivery open-source scalability
/kind enhancement
What this PR does / why we need it:
This PR adds TM test for the worker pools with InPlace update strategy, the test verifies that after performing update the nodes should remain the same.
Which issue(s) this PR fixes:
Part of #10219
Special notes for your reviewer:
Release note: