Skip to content

[GEP-28] Move KUBECONFIG from machine level to ~/.bashrc #11975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

[GEP-28] Move KUBECONFIG from machine level to ~/.bashrc #11975

merged 3 commits into from
Apr 30, 2025

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area ipcei
/kind enhancement

What this PR does / why we need it:

This PR ensures that the ASC's components running in the machine pod don't accidentally use the KUBECONFIG env var or any credentials for the underlying kind cluster.
We still keep the convenience for developers by adding the KUBECONFIG env var to ~/.bashrc. Additionally, the k alias is added.

Which issue(s) this PR fixes:
Part of #2906

Special notes for your reviewer:

/cc @rfranzke

Release note:

NONE

@gardener-prow gardener-prow bot requested a review from rfranzke April 29, 2025 15:53
@gardener-prow gardener-prow bot added area/ipcei IPCEI (Important Project of Common European Interest) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2025
@timebertt timebertt mentioned this pull request Apr 29, 2025
Open
@rfranzke
Copy link
Member

/assign

@rfranzke
Copy link
Member

/retest

@rfranzke
Copy link
Member 

  [FAILED] Unexpected error:
      <*fmt.wrapError | 0xc0003bda20>: 
      failed to execute command: Internal error occurred: Internal error occurred: error executing command in container: failed to exec in container: failed to start exec "0c867ea2335ee4d316fcde1be24a4f1658d6ab78951e4a236a8798cf208fdf5b": OCI runtime exec failed: exec failed: unable to start container process: exec: "gardenadm": executable file not found in $PATH: unknown
      {
          msg: "failed to execute command: Internal error occurred: Internal error occurred: error executing command in container: failed to exec in container: failed to start exec \"0c867ea2335ee4d316fcde1be24a4f1658d6ab78951e4a236a8798cf208fdf5b\": OCI runtime exec failed: exec failed: unable to start container process: exec: \"gardenadm\": executable file not found in $PATH: unknown",
          err: <*errors.errorString | 0xc00029dec0>{
              s: "Internal error occurred: Internal error occurred: error executing command in container: failed to exec in container: failed to start exec \"0c867ea2335ee4d316fcde1be24a4f1658d6ab78951e4a236a8798cf208fdf5b\": OCI runtime exec failed: exec failed: unable to start container process: exec: \"gardenadm\": executable file not found in $PATH: unknown",
          },
      }
  occurred
  In [It] at: /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardenadm/hightouch/gardenadm.go:67 @ 04/30/25 08:40:28.906

👀

@timebertt
Merge both container hooks
1a207f9 
skaffold visits containers selected by multiple hooks only once.
I.e., because there were two hooks selecting the machine pods,
the second one (which installs `gardenadm`) was skipped, causing
the tests to fail.
@timebertt
Copy link
Member Author

The gardenadm test failure should be fixed with the latest commit. There was some weird skaffold behavior around the lifecycle hooks that I wasn't aware of. I missed this during local testing because I didn't have fresh machine pod volumes.

rfranzke
rfranzke reviewed Apr 30, 2025
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Apr 30, 2025

LGTM label has been added.

Git tree hash: b1434072ef0f2b2fac71f6e895cb4fd2bf3e7e08

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2025
@gardener-prow gardener-prow bot merged commit 1469e55 into gardener:master Apr 30, 2025
19 checks passed
@timebertt timebertt deleted the gardenadm-kubeconfig branch April 30, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timebertt @rfranzke