Add pod cache to gardener-node-agent only when nodeName is present
#11964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acumino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 7d1edbd4958061aa96eafcf3b9c49d0eff946355
|
40 tasks
1b8f70a to
0e58190
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: d3856df6adf356647a407b61febc47e6bd12deae
|
|
/test pull-gardener-e2e-kind-operator-seed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind bug
What this PR does / why we need it:
This PR adapts
gardener-node-agentto add a cache for pods only if thenodeNameis present. We use thenodeNamein thenode-agent-authorizerwebhook to ensure that podlistrequests for only the same node are allowed.During the startup, nodeName can be empty in some providers (eg: aws), and starting the cache with
hostNamecan fail since the webhook doesn't know about this hostName.We restart
gardener-node-agentas soon as it identifies it's node for the first time, ref, the cache will be added during that time.Which issue(s) this PR fixes:
Part of #10219
Special notes for your reviewer:
Introduced with #11718
/cc @acumino @oliver-goetz
Release note: