[GEP-28] gardenadm token commands
#11934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM label has been added. Git tree hash: 6747a377a144038b858593b8301ca3623dc976dd
|
|
/assign |
ScheererJ
reviewed
Apr 30, 2025
timebertt
requested changes
May 5, 2025
Previously, a random secret was generated in all cases. For `gardenadm token create`, we have to support that the user specifies a desired token secret.
This will be used by `gardenadm token create` and `gardenadm token generate`
- generates a new bootstrap token secret with random id and secret
- move create utils into `create` package
|
/lgtm |
|
LGTM label has been added. Git tree hash: 14f0e8604b127b558d878cd4d2fe3f7fb2aa355d
|
timebertt
approved these changes
May 6, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area ipcei
/kind enhancement
What this PR does / why we need it:
This PR implements the
gardenadm tokensubcommands:gardenadm token list [--with-token-secrets]to list the bootstrap tokens in a nice tablegardenadm token generateto generate a new random bootstrap tokengardenadm token create <token>to create a new, user-defined bootstrap tokengardenadm token delete <token-values>to delete bootstrap tokensIn addition, it is possible to print the
gardenadm joincommand (via--print-join-command). This increases convenience for users. Note that thejoincommand is not yet implemented (subsequent PR will follow).Which issue(s) this PR fixes:
Part of #2906
Release note: