Skip to content

Add check for rolling update in CheckNodesScaling #11869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 12, 2025
Merged

Add check for rolling update in CheckNodesScaling #11869

merged 5 commits into from
May 12, 2025

Conversation

RadaBDimitrova
Copy link
Contributor

@RadaBDimitrova RadaBDimitrova commented Apr 15, 2025 •
edited by ialidzhikov
Loading

How to categorize this PR?

/area quality
/kind enhancement

What this PR does / why we need it:
This PR is the implementation for the agreed upon #11084 (comment)

test run:

- lastTransitionTime 2025-04-01T071249Z

Which issue(s) this PR fixes:
Fixes #10227

Special notes for your reviewer:
cc @plkokanov @Kostov6

Release note:

gardenlet's shoot-care controller : An issue causing gardenlet to report a misleading reason (`NodesScalingDown`) during rolling update of Shoot Nodes is now fixed.

@gardener-prow gardener-prow bot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension labels Apr 15, 2025
@gardener-prow gardener-prow bot requested review from Kostov6 and timuthy April 15, 2025 07:14
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 15, 2025
timuthy
timuthy requested changes Apr 16, 2025
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement 🙂

@gardener-prow gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2025
@RadaBDimitrova RadaBDimitrova requested a review from timuthy April 17, 2025 06:07
timuthy
timuthy reviewed Apr 17, 2025
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Apr 17, 2025

LGTM label has been added.

Git tree hash: d3a71c6108bf0e74ed39b546766e6bf13b6f6a72

@RadaBDimitrova
Copy link
Contributor Author

/retest

@timuthy
Copy link
Member

timuthy commented Apr 28, 2025

Do you still plan to check this PR @Kostov6? Otherwise, I'll approve.

@Kostov6
Copy link
Contributor

Kostov6 commented Apr 28, 2025

Do you still plan to check this PR @Kostov6? Otherwise, I'll approve.

Today I'll take a final look at it

Kostov6
Kostov6 reviewed Apr 30, 2025
View reviewed changes
Copy link
Contributor

@Kostov6 Kostov6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use NodesRollOutScalingUp instead. Otherwise lgtm

@plkokanov
Copy link
Contributor

Do you still plan to check this PR @Kostov6? Otherwise, I'll approve.

Let me also have a quick look a bit later tonight :)
/assign

plkokanov
plkokanov reviewed May 2, 2025
View reviewed changes
Copy link
Contributor

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.
/lgtm
Just a small typo that you could fix.

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2025
@gardener-prow gardener-prow bot requested review from Kostov6, plkokanov and timuthy May 2, 2025 07:24
@plkokanov
Copy link
Contributor

/lgtm

@timuthy leaving the approval to you :)

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 7, 2025

LGTM label has been added.

Git tree hash: edb1a26253ea1a48a279e25cbf283d104211d522

@timuthy
Copy link
Member

timuthy commented May 12, 2025

/approve

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timuthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2025
@RadaBDimitrova
Copy link
Contributor Author

[FAILED] Timed out after 5.001s. Expected <map[string]string | len:3>: { "kubernetes.io/hostname": "test-hostname", "osc-controller-test": "test-357a3a4a", "worker.gardener.cloud/kubernetes-version": "1.2.3", } to have {key: value} <map[interface {}]interface {} | len:1>: { <string>"node.machine.sapcloud.io/update-result": <string>"successful", }
/retest

@gardener-prow gardener-prow bot merged commit db76f6f into gardener:master May 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kostov6 Kostov6 Awaiting requested review from Kostov6

@plkokanov plkokanov Awaiting requested review from plkokanov

@timuthy timuthy Awaiting requested review from timuthy

Assignees

@Kostov6 Kostov6

@plkokanov plkokanov

@timuthy timuthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node with critical-components-not-ready pod will be reported as NodesScalingDown in EveryNodeReady condition
4 participants
@RadaBDimitrova @timuthy @Kostov6 @plkokanov