Skip to content

[GEP-31] Introduce Shoot status reconciler for maintaining in-place update status #11844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 21, 2025
Merged

[GEP-31] Introduce Shoot status reconciler for maintaining in-place update status #11844

merged 8 commits into from
Apr 21, 2025

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Apr 8, 2025 •
edited
Loading

How to categorize this PR?

/area control-plane delivery open-source scalability
/kind enhancement

What this PR does / why we need it:

  • Add a new controller in gardenlet to update shoot status based on worker status change for manual in-place updates
  • Add an optional constraint in the Shoot to notify that a manual in-place update is still pending (since Shoot reconciliation will succeed in this case).

Which issue(s) this PR fixes:
Part of #10219

Special notes for your reviewer:
Depends on #11843
/hold
Initially part of #11713

Release note:

NONE

@gardener-prow gardener-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/control-plane Control plane related area/delivery Delivery related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/scalability Scalability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Apr 8, 2025
@gardener-prow gardener-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 8, 2025
@shafeeqes shafeeqes mentioned this pull request Apr 8, 2025
Open
40 tasks
@shafeeqes shafeeqes force-pushed the inplace-updates-worker-3 branch 3 times, most recently from 6bdabdb to bfb7ad7 Compare April 9, 2025 08:13
@shafeeqes shafeeqes mentioned this pull request Apr 11, 2025
Merged
rfranzke
rfranzke reviewed Apr 15, 2025
View reviewed changes
@shafeeqes shafeeqes force-pushed the inplace-updates-worker-3 branch from 5f9cab6 to 91e8c12 Compare April 16, 2025 05:30
@shafeeqes
Copy link
Contributor Author

/retest

@rfranzke
Copy link
Member

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Apr 16, 2025

LGTM label has been added.

Git tree hash: 69316755792a3ae9abf0e0074ff5ff1ada4788b2

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2025
@acumino
Copy link
Member

acumino commented Apr 18, 2025

/assign

@acumino acumino force-pushed the inplace-updates-worker-3 branch from 91e8c12 to b8d0353 Compare April 18, 2025 13:23
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2025
@gardener-prow gardener-prow bot requested review from acumino and rfranzke April 18, 2025 13:24
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2025
acumino
acumino requested changes Apr 18, 2025
View reviewed changes
shafeeqes and others added 8 commits April 21, 2025 13:57
@shafeeqes @acumino
Add a new controller in gardenlet to update Shoot status manual in-pl…
665ccb7 
…ace pending workers
@shafeeqes @acumino
Add integration tests
3dfd2fb
@shafeeqes @ary1992 @acumino
Add optional constraint to Shoot to mark that there are pending manua…
c3ba7f9 
…l-inplace updates

Co-Authored-By: Ashish Ranjan Yadav <ashish.ranjan.yadav@sap.com>
Co-Authored-By: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
@shafeeqes @ary1992 @acumino
Run make generate
3dc37bf 
Co-Authored-By: Ashish Ranjan Yadav <ashish.ranjan.yadav@sap.com>
Co-Authored-By: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
@shafeeqes @acumino
Update skaffold dependencies
4321dfd
@shafeeqes @acumino
Address PR review feedback from rfranzke
9fc2dfe
@shafeeqes @acumino
Improve unit tests
34c6102
@acumino
Address Review
2aa2be8
@acumino acumino force-pushed the inplace-updates-worker-3 branch from b8d0353 to 2aa2be8 Compare April 21, 2025 08:27
acumino
acumino reviewed Apr 21, 2025
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Apr 21, 2025

LGTM label has been added.

Git tree hash: 2180837b9002369a3fd038100cd17040697f3cbc

@acumino acumino removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Apr 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acumino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2025
@gardener-prow gardener-prow bot merged commit 5107e93 into gardener:master Apr 21, 2025
19 checks passed
@shafeeqes shafeeqes deleted the inplace-updates-worker-3 branch April 21, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino acumino requested changes

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees

@rfranzke rfranzke

@acumino acumino

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related area/delivery Delivery related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/scalability Scalability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shafeeqes @rfranzke @acumino