[GEP-28] Bootstrap kubelet and make gardenadm init idempotent
#11749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
/assign |
ScheererJ
reviewed
Mar 27, 2025
pkg/component/extensions/operatingsystemconfig/original/components/nodeagent/rbac.go
Outdated
Show resolved
Hide resolved
ScheererJ
approved these changes
Mar 27, 2025
|
LGTM label has been added. Git tree hash: 8d4df7fa448bd226c7a4a7a7fe6f5ab3c21cfb22
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScheererJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The `ExtraIPAddresses` are already appended in L169 Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com>
- create client for cluster using admin kubeconfig - create and write real bootstrap token - create RBAC resources for TLS bootstrapping - restart kubelet to pick up token and bootstrap Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com>
- if kubernetes control plane has already been deployed, just use the kubeconfig, create a clientset, and continue from there - import secrets from fake client into real cluster to prevent regeneration on new `gardenadm init` invocations Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com>
Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com>
This gets relevant when the kubelet registers the node and creates mirror pods for the static pods. It seems to use the node IP to connect to the pods, however, etcd only binds to the loopback device. Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com>
Otherwise, we had to create the CRDs before we create the botanist object. Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com>
For example, finalizers/resourceVersion/... is not needed and should not be considered when translating to a static pod manifest. Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com>
Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com>
Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com>
It was always using a free port, even if a local port was explicitly specified. Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com>
|
/lgtm |
|
LGTM label has been added. Git tree hash: 1b2df350bd3166557d5764aa393ed5fdabed5263
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area ipcei
/kind enhancement
What this PR does / why we need it:
This PR is the next increment for
gardenadm init. It bootstraps thekubeletand makes thegardenadm initinvocations idempotent (under the assumption that the initial control plane deployment worked - otherwise, you have to start from scratch).Which issue(s) this PR fixes:
Part of #2906
Special notes for your reviewer:
Still in draft since it's based on #11701 which must be merged first./cc @ScheererJ
Release note: