Skip to content

Graduate feature gate NewVPN to Beta #11693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2025
Merged

Graduate feature gate NewVPN to Beta #11693

merged 2 commits into from
Mar 18, 2025

Conversation

ScheererJ
Copy link
Member

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:

Graduate feature gate NewVPN to Beta.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The feature gate `NewVPN` has been graduated to `Beta` and is now enabled by default.

@gardener-prow gardener-prow bot added area/networking Networking related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2025
@gardener-prow gardener-prow bot requested review from ialidzhikov and rfranzke March 18, 2025 11:48
@ScheererJ
Copy link
Member Author

/cc @DockToFuture @axel7born @MartinWeindel

DockToFuture
DockToFuture approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 18, 2025

LGTM label has been added.

Git tree hash: 39cd1edc038d4e85949d7dd2b6c32db7330b1a70

ialidzhikov
ialidzhikov reviewed Mar 18, 2025
View reviewed changes
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2025
@gardener-prow gardener-prow bot requested a review from DockToFuture March 18, 2025 12:18
ialidzhikov
ialidzhikov reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comment: could we also drop

gardener/example/gardener-local/gardenlet/values.yaml

Line 41 in 1e5a462

NewVPN: true
as the feature gate is now enabled by default and there is no need to explicitly enable it for the local setup?

UPDATE: It was already part of this PR! 😓

ialidzhikov
ialidzhikov approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 18, 2025

LGTM label has been added.

Git tree hash: 67c2ee74cd1e47188d8352809cf8cb6ad2e9a088

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DockToFuture, ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@ialidzhikov ialidzhikov changed the title Graduate feature gate NewVPN to Beta. Graduate feature gate NewVPN to Beta Mar 18, 2025
MartinWeindel
MartinWeindel reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot merged commit 8bd611c into gardener:master Mar 18, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@rfranzke rfranzke Awaiting requested review from rfranzke

@axel7born axel7born Awaiting requested review from axel7born

@DockToFuture DockToFuture Awaiting requested review from DockToFuture

+1 more reviewer

@MartinWeindel MartinWeindel MartinWeindel left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@MartinWeindel MartinWeindel

@ialidzhikov ialidzhikov

@DockToFuture DockToFuture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking Networking related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScheererJ @MartinWeindel @ialidzhikov @DockToFuture