-
Notifications
You must be signed in to change notification settings - Fork 526
Remove HPA
from gardener-apiserver
#11684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HPA
from gardener-apiserver
#11684
Conversation
/cc @voelzmo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: ab79abd0cb2104cadc5f2ef8a5c5328b95144a82
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area auto-scaling control-plane
/kind enhancement
What this PR does / why we need it:
kube-apiservers create a single HTTP2 connection to extension API-servers as
gardener-apiserver
.This means that if there are more
gardener-apiservers
thankube-apiservers
in the garden control plane, the "excess"gardener-apiservers
do not get any requests.The consequences of this behavior are:
There is a high change that this scenario happens because there is usually more load on GAPIs than on the KAPIs in the gardener-controlplane.
Thus, this PR removes
HPA
fromgardener-apiserver
and sets its replicas to 3 in HA case and 2 in the non-HA case. This way we ensure that there are not more GAPIs than KAPIs.Additionally, the max allowed requests are increased since this is now the only autoscaling mechanism for GAPI.
There could be other options to solve this problem e.g. disabling HTTP2 in GAPIs to force KAPIs to create more connections.
However, it is hard to estimate the consequences of this change and it would need further investigations.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: