Skip to content

Conversation

chrkl
Copy link
Member

@chrkl chrkl commented Mar 13, 2025

How to categorize this PR?

/area monitoring
/kind bug

What this PR does / why we need it:

The API server Plutono dashboard contains a authentication panel that visualizes the following metrics:

authenticated_user_requests
authentication_attempts

These metrics were not whitlisted in the related ServiceMonitor.

This PR adds the missing metrics to the ServiceMonitor.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/cc @istvanballok @rickardsjp @vicwicker

Release note:

Fix authentication panel in API server Plutono dashboard for Shoot clusters

Copy link
Contributor

gardener-prow bot commented Mar 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/monitoring Monitoring (including availability monitoring and alerting) related kind/bug Bug labels Mar 13, 2025
@gardener-prow gardener-prow bot requested review from ary1992 and timuthy March 13, 2025 14:32
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2025
@chrkl chrkl marked this pull request as ready for review March 13, 2025 14:59
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2025
The API server Plutono dashboard contains a authentication panel
that visualizes the following metrics:

authenticated_user_requests
authentication_attempts

These metrics were not whitlisted in the related ServiceMonitor.

This PR adds the missing metrics to the ServiceMonitor.
@chrkl chrkl force-pushed the fix-shoot-apiserver-dashboard branch from 897f352 to 94c08c3 Compare March 13, 2025 19:46
@chrkl
Copy link
Member Author

chrkl commented Mar 13, 2025

/test pull-gardener-e2e-kind-ipv6

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

gardener-prow bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025
@rickardsjp
Copy link
Member

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2025
Copy link
Contributor

gardener-prow bot commented Mar 14, 2025

LGTM label has been added.

Git tree hash: 5c84e0443cde7547fc23d4728d2e19a129fbd78e

@gardener-prow gardener-prow bot merged commit bbc368f into gardener:master Mar 14, 2025
19 checks passed
@chrkl chrkl deleted the fix-shoot-apiserver-dashboard branch March 14, 2025 11:19
@rickardsjp rickardsjp removed their assignment Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants