Skip to content

Default injectGardenKubeconfig to true for Worker extensions in operator.gardener.cloud/v1alpha1.Extension API #11658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Default injectGardenKubeconfig to true for Worker extensions in operator.gardener.cloud/v1alpha1.Extension API #11658

merged 1 commit into from
Mar 13, 2025

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area usability
/kind enhancement

What this PR does / why we need it:
Follow-up of #11593. As Worker extensions usually use the generic Actuator which requires passing a cluster.Cluster for the garden, we default the injectGardenKubeconfig setting to true for extensions reconciling Worker resources.

gardener/extensions/pkg/controller/worker/genericactuator/actuator.go

Line 44 in 20d3fad

func NewActuator(mgr manager.Manager, gardenCluster cluster.Cluster, delegateFactory DelegateFactory, errorCodeCheckFunc healthcheck.ErrorCodeCheckFunc) worker.Actuator {

Release note:

The `injectGardenKubeconfig` field is defaulted to `true` for extensions responsible for `Worker` resources when registered via the `operator.gardener.cloud/v1alpha1.Extension` API.

@rfranzke
Default injectGardenKubeconfig to true for Worker extensions in…
7ed3486 
… `operator.gardener.cloud/v1alpha1.Extension` API
@gardener-prow gardener-prow bot added area/usability Usability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Mar 12, 2025
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 12, 2025
@ScheererJ
Copy link
Member

/assign

ScheererJ
ScheererJ approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making the transition easier for provider extensions after #11593.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 13, 2025

LGTM label has been added.

Git tree hash: 07614c8393e98c6dad4420a05854a86356cc5e52

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2025
@gardener-prow gardener-prow bot merged commit e780ecb into gardener:master Mar 13, 2025
19 checks passed
@rfranzke rfranzke deleted the inject-garden-default-worker branch March 13, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

@acumino acumino Awaiting requested review from acumino

@LucaBernstein LucaBernstein Awaiting requested review from LucaBernstein

Assignees

@ScheererJ ScheererJ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfranzke @ScheererJ