Skip to content

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind enhancement

What this PR does / why we need it:

#11252 added a minAllowed configuration option to set initial VPA values for a shoot's control plane.

To make use of this feature in testmachinery tests, the flag needs to be exposed by the test definition.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

cc @dguendisch @timuthy

Release note:

`CreateShoot` testdefinition exposes `minAllowed` options for control plane

@gardener-prow gardener-prow bot added area/testing Testing related kind/enhancement Enhancement, improvement, extension labels Mar 10, 2025
@gardener-prow gardener-prow bot requested review from marc1404 and plkokanov March 10, 2025 15:49
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2025
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2025
Copy link
Contributor

gardener-prow bot commented Mar 10, 2025

LGTM label has been added.

Git tree hash: a9a79bb68e30fc386679ec0d5c9997e8251a29de

Copy link
Contributor

gardener-prow bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2025
@hendrikKahl
Copy link
Contributor Author

/retest

@gardener-prow gardener-prow bot merged commit 6f602d8 into gardener:master Mar 11, 2025
19 checks passed
@hendrikKahl hendrikKahl deleted the test/expose-minAllowed branch March 11, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Testing related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants