[GEP 31] Adapt API changes for machine-controller-manager
#11631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
c7eb68b to
c2559f7
Compare
|
/retest |
shafeeqes
reviewed
Mar 11, 2025
…althTimeout` supported by MCM Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com> Co-Authored-By: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com> Co-Authored-By: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com> Co-Authored-By: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com> Co-Authored-By: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com> Co-Authored-By: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
…f the worker pool Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com> Co-Authored-By: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com> Co-Authored-By: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
088d3f2 to
7d9b29c
Compare
shafeeqes
reviewed
Mar 12, 2025
07b348f to
6a82954
Compare
machine-controller-manager
|
/lgtm |
|
LGTM label has been added. Git tree hash: 1ba1ee538cc05080a5ea482a59b56d950e95e473
|
rfranzke
requested changes
Mar 13, 2025
fb2f8bf to
9ec2f05
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: b782cdb4fd8ded9edb5d81bcee0b1948cd4927b4
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acumino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ialidzhikov
reviewed
Mar 18, 2025
| @@ -1715,6 +1719,13 @@ type MachineControllerManagerSettings struct { | |||
| // NodeConditions are the set of conditions if set to true for the period of MachineHealthTimeout, machine will be declared failed. | |||
| // +optional | |||
| NodeConditions []string `json:"nodeConditions,omitempty" protobuf:"bytes,5,name=nodeConditions"` | |||
| // MachineInPlaceUpdateTimeout is the timeout after which in-place update is declared failed. | |||
| // +optional | |||
| MachineInPlaceUpdateTimeout *metav1.Duration `json:"inPlaceUpdateTimeout,omitempty" protobuf:"bytes,6,opt,name=inPlaceUpdateTimeout"` | |||
There was a problem hiding this comment.
Why the field is not called InPlaceUpdateTimeout? Due to it, right now it generates the following api violation:
API rule violation: names_match,github.com/gardener/gardener/pkg/apis/core/v1beta1,MachineControllerManagerSettings,MachineInPlaceUpdateTimeout
There was a problem hiding this comment.
Fields here are more or less direct copies of fields defined in MCM here. To follow the same convention like other fields MachineInPlaceUpdateTimeout was named based on the new field in MCM MachineInPlaceUpdateTimeout .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Shafeeque E S shafeeque.e.s@sap.com
Co-Authored-By: Sonu Kumar Singh sonu.kumar.singh02@sap.com
How to categorize this PR?
/area control-plane delivery open-source scalability
/kind enhancement
What this PR does / why we need it:
This PR adapts the MCM API changes. Defaulting and validations are also added to the introduced field.
Which issue(s) this PR fixes:
Part of #10219
Special notes for your reviewer:
Release note: