Refactor seed integration test not to use gstruct Matcher
#11616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8da11a to
c00eea0
Compare
timuthy
requested changes
Mar 10, 2025
test/utils/matchers/matchers.go
Outdated
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| ) | ||
|
|
||
| // ObjectNames takes an ObjectList and returns a list of the objects within this list. |
There was a problem hiding this comment.
Suggested change
| // ObjectNames takes an ObjectList and returns a list of the objects within this list. | |
| // ObjectNames takes an ObjectList and returns the corresponding names of the objects. |
test/utils/matchers/matchers.go
Outdated
There was a problem hiding this comment.
Move to github.com/gardener/gardener/pkg/utils/test/matchers or github.com/gardener/gardener/pkg/utils/test?
|
LGTM label has been added. Git tree hash: da114db5467f3ca1c3cdb7baf5f19e96f83cd13f
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LucaBernstein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area testing
/kind cleanup
What this PR does / why we need it:
As mentioned in #11386 (comment), this change aligns the output to this change, improving test output in error cases.
Before, we just used the
gstructmatcher in this case to see if names of Objects align. In an error case,ginkgoprints out the entire struct (which are lists in this case), leading to truncated output.With this change, this test also just matches for the name, shortening the output and making it more readable
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I was not sure where to extract the
objectNames()function to, for me this place felt the most fitting, because I could not find a better place intest/utils. I am not satisfied with the name of the package, but could not find a better one.Release note: