Document how to federate metrics from the shoot Prometheus #11609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
LGTM label has been added. Git tree hash: 384655fda48e5a967149e3d60aae94a9d8f3ede0
|
1 task
rickardsjp
reviewed
Mar 6, 2025
There was a problem hiding this comment.
This guide is sort of specific to the API server metrics, and I don't really see a reason not to generalize this into a guide on federating from control plane Prometheus instances in general.
Additionally, I think we should mention that we've got an OTel based approach in the works.
WDYT?
rickardsjp
reviewed
Mar 6, 2025
Co-authored-by: Jeremy Rickards <jeremy.rickards@sap.com>
f43448b to
0a8ea26
Compare
|
LGTM label has been added. Git tree hash: e6d0b1903595b7213acc390df86bbb7dcb0fe467
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke, rickardsjp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area documentation
/kind enhancement
What this PR does / why we need it:
This motivates the federation from the shoot Prometheus as the proper way for shoot owners to collect control-plane metrics and includes a configuration example.
Special notes for your reviewer:
/cc @rickardsjp @chrkl @vpnachev
Release note: