Skip to content

Override machine image updateStrategy from NamespacedCloudProfile #11550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 6, 2025
Merged

Override machine image updateStrategy from NamespacedCloudProfile #11550

merged 5 commits into from
Mar 6, 2025

Conversation

LucaBernstein
Copy link
Member

How to categorize this PR?

/area ops-productivity os usability
/kind enhancement

What this PR does / why we need it:
Enable the updateStrategy of existing machine images to be overridden in a NamespacedCloudProfile.

Which issue(s) this PR fixes:
Part of #11520.

Special notes for your reviewer:
/cc @timuthy @rfranzke

Release note:

The `updateStrategy` of existing machine images in a `CloudProfile` can now be overridden in a `NamespacedCloudProfile`.

@gardener-prow gardener-prow bot requested review from rfranzke and timuthy February 28, 2025 14:31
@gardener-prow gardener-prow bot added area/ops-productivity Operator productivity related (how to improve operations) area/os Operator system related area/usability Usability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2025
@LucaBernstein
Copy link
Member Author

/retest
Failing due to #11532

@LucaBernstein LucaBernstein linked an issue Mar 3, 2025 that may be closed by this pull request
Override OS updateStrategy per shoot resource #11520
Closed
timuthy
timuthy requested changes Mar 4, 2025
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

@LucaBernstein LucaBernstein force-pushed the 11520-override-os-updatestrategy-nscpfl branch from e471a92 to bc9fa26 Compare March 4, 2025 08:24
@LucaBernstein LucaBernstein requested a review from timuthy March 4, 2025 08:24
@LucaBernstein LucaBernstein force-pushed the 11520-override-os-updatestrategy-nscpfl branch from bc9fa26 to 138b9bc Compare March 4, 2025 08:43
timuthy
timuthy reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 4, 2025

LGTM label has been added.

Git tree hash: b43bc7c287735100a04895a108cdf4d6c1eba5f3

rfranzke
rfranzke reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2025
@gardener-prow gardener-prow bot merged commit 404a0de into gardener:master Mar 6, 2025
19 checks passed
@LucaBernstein LucaBernstein deleted the 11520-override-os-updatestrategy-nscpfl branch March 7, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@timuthy timuthy timuthy requested changes

Assignees

@timuthy timuthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ops-productivity Operator productivity related (how to improve operations) area/os Operator system related area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override OS updateStrategy per shoot resource
3 participants
@LucaBernstein @rfranzke @timuthy