[GEP-28] Read resources from disk + initialize botanist #11517
Conversation
e837416 to
8ca47b2
Compare
|
/assign |
|
/assign |
We use `fakeclient` for the fake ctrl-runtime client, so let's use `fakekubernetes` for the fake kubernetes clientset interface.
- exemplary first task in this flow - since we use gardenlet code, we also register its feature gates - unit test is dropped since this flow will grow quite substantially, so it's pointless to try to unit-test it (similar to shoot reconciliation flow in `gardenlet`)
- for non-essential things (at least in this point in time), we don't want to provide "fake configuration" to the botanist just to make the code work - instead, let's make things optional where possible/non-essential - this might change in the future when the `init` flow evolves, but for now/to get started, we want to provide minimal configuration
- at least the CloudProfile for now, later also
Controller{Registration,Deployment}
Co-Authored-By: Tim Ebert <timebertt@gmail.com>
…eneration The `.status.uid` is meant to carry a unique UID for a `Shoot`, hence, this one should be used when generating technical names. The `.metadata.uid` can change when the `Shoot` is deleted and re-created in etcd/the API server. Co-Authored-By: Tim Ebert <timebertt@gmail.com>
- also addresses other nits of the PR feedback Co-Authored-By: Tim Ebert <timebertt@gmail.com>
Co-Authored-By: Tim Ebert <timebertt@gmail.com>
|
LGTM label has been added. Git tree hash: 9c54df5b59f107f3aa49f43da24f9611b54bf02a
|
|
@rfranzke: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScheererJ, timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area ipcei
/kind enhancement
What this PR does / why we need it:
This PR augments
gardenadm initto read the resources (Shoot,CloudProfile,Project) from disk and use them to initialize a newBotanistobject in order to run the first flow task./cc @ScheererJ @timebertt
Which issue(s) this PR fixes:
Part of #2906
Release note: