[GRM] Drop TokenInvalidator controller and webhook and disable PodTopologySpreadConstraints webhook in favour of matchLabelKeys in deployment
#11497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
29 tasks
e510ef5 to
21e1f62
Compare
|
/cc @timuthy |
21e1f62 to
576a4e3
Compare
|
/retest |
timuthy
reviewed
Feb 27, 2025
|
LGTM label has been added. Git tree hash: 05b090194c96b44ba79c3481ffbf4e01713015a1
|
|
Upgrade tests seem to be failing consistently, will take a look. |
…e Deployment in `HighAvailabilityConfig` webhook for the match label keys For shoots, disable it only if the `MatchLabelKeysInPodTopologySpread` feature gate is disabled in kube-apiserver and kube-scheduler
…tation from seed resources
576a4e3 to
6b8d4e4
Compare
|
LGTM label has been added. Git tree hash: 75d686de0e2decac24b1fe02f9ac32eace163ce7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timuthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind cleanup
What this PR does / why we need it:
TokenInvalidatorcontroller. In 1.27LegacyServiceAccountTokenNoAutoGenerationbecomesLockToDefault: trueref.MatchLabelKeysInPodTopologySpreadfeature gate is beta since kubernetesv1.27ref. DisablePodTopologySpreadConstraintswebhook for seeds and usespec.topologySpreadConstraints[*].matchLabelKeysin deployments. Only enablePodTopologySpreadConstraintsfor Shoots if the kubernetes feature gate is disabled explicitly.Which issue(s) this PR fixes:
Part of #10339
Special notes for your reviewer:
Need to adapt some tests, hence in draft.
Release note: