[release-v1.112] Rename seed.gardener.cloud/ prefix to name.seed.gardener.cloud/
#11486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to potential naming conflicts when users also use `seed.gardener.cloud/` as prefix for their labels (not ideal, they should actually use a unique prefix (e.g., `seed.my.cool.domain.com/`), but we cannot prevent it for historic reasons
|
/test pull-gardener-integration-release-v1-112 |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 9da51c912faa1a1874ce7bc9e784f8e756d1d70e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shafeeqes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Duciwuci
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Feb 25, 2025
…ardener.cloud/` (gardener#11486) * Rename `seed.gardener.cloud/` prefix to `.name.seed.gardener.cloud/` due to potential naming conflicts when users also use `seed.gardener.cloud/` as prefix for their labels (not ideal, they should actually use a unique prefix (e.g., `seed.my.cool.domain.com/`), but we cannot prevent it for historic reasons * Migration code in GCM to re-compute seed labels * Address PR review feedback --------- Co-authored-by: rfranzke <rafael.franzke@sap.com>
ske-prow bot
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Feb 25, 2025
* Prepare next Development Cycle v1.112.3-dev * Prevent concurrent map read/writes in `Extension` deployer component (gardener#11467) Co-authored-by: rfranzke <rafael.franzke@sap.com> * [release-v1.112] Rename `seed.gardener.cloud/` prefix to `name.seed.gardener.cloud/` (gardener#11486) * Rename `seed.gardener.cloud/` prefix to `.name.seed.gardener.cloud/` due to potential naming conflicts when users also use `seed.gardener.cloud/` as prefix for their labels (not ideal, they should actually use a unique prefix (e.g., `seed.my.cool.domain.com/`), but we cannot prevent it for historic reasons * Migration code in GCM to re-compute seed labels * Address PR review feedback --------- Co-authored-by: rfranzke <rafael.franzke@sap.com> * Release v1.112.3 --------- Co-authored-by: gardener-robot-ci-1 <gardener.ci.user@gmail.com> Co-authored-by: Gardener Prow Robot <gardener.ci.robot@gmail.com> Co-authored-by: rfranzke <rafael.franzke@sap.com> Co-authored-by: gardener-robot-ci-2 <gardener.ci.user2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #11479
/assign rfranzke