Skip to content

[release-v1.113] Rename seed.gardener.cloud/ prefix to name.seed.gardener.cloud/ #11485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 22, 2025
Merged

[release-v1.113] Rename seed.gardener.cloud/ prefix to name.seed.gardener.cloud/ #11485

merged 3 commits into from
Feb 22, 2025

Conversation

gardener-ci-robot
Copy link
Contributor

@gardener-ci-robot gardener-ci-robot commented Feb 21, 2025 •
edited
Loading

This is an automated cherry-pick of #11479

/assign rfranzke

A bug which prevented usage of labels with `seed.gardener.cloud/` prefix on `Seed`, `ManagedSeed`, `BackupEntry`, and `Shoot` resources has been fixed.

@rfranzke
Rename seed.gardener.cloud/ prefix to .name.seed.gardener.cloud/
542478a 
due to potential naming conflicts when users also use
`seed.gardener.cloud/` as prefix for their labels (not ideal, they
should actually use a unique prefix (e.g., `seed.my.cool.domain.com/`),
but we cannot prevent it for historic reasons
@rfranzke
Migration code in GCM to re-compute seed labels
fe76e2a
@rfranzke
Address PR review feedback
b6f392f
@gardener-ci-robot gardener-ci-robot mentioned this pull request Feb 21, 2025
Merged
@gardener-ci-robot gardener-ci-robot added area/usability Usability related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution labels Feb 21, 2025
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 21, 2025
plkokanov
plkokanov reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 21, 2025

LGTM label has been added.

Git tree hash: fe75f2e937a9cc358af1c1e67b753e018fcfde73

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: plkokanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Feb 21, 2025
@plkokanov
Copy link
Contributor

/test pull-gardener-e2e-kind-migration-ha-single-zone-release-v1-113

@shafeeqes
Copy link
Contributor

/retest

@gardener-prow gardener-prow bot merged commit 3820526 into gardener:release-v1.113 Feb 22, 2025
18 checks passed
@gardener-ci-robot gardener-ci-robot deleted the cherry-pick-11479-to-release-v1.113 branch February 22, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plkokanov plkokanov plkokanov left review comments

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

@timebertt timebertt Awaiting requested review from timebertt

Assignees

@rfranzke rfranzke

@plkokanov plkokanov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gardener-ci-robot @plkokanov @shafeeqes @rfranzke