[GEP-28] Refactor gardenadm unit tests to gbytes.Buffer
#11446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfranzke
reviewed
Feb 19, 2025
|
/lgtm |
|
LGTM label has been added. Git tree hash: 06580d08db212d445694c3cc25ed57ed9d88fd98
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area ipcei
/kind enhancement
What this PR does / why we need it:
This PR follows-up on #11390 and refactors the gardenadm unit tests to use
gbytes.Buffer. This pairs nicely with our use of ginkgo and gomega.There is a new
clitest.NewTestIOStreams()similar togenericiooptions.NewTestIOStreams()that initializes the buffers. Tests can then useEventually(stdErr).Should(Say("something"))to assert logging outputs.Which issue(s) this PR fixes:
Part of #2906
Special notes for your reviewer:
/cc @rfranzke
Release note: