Skip to content

Fix CalculateMaxNodesForShoot for cluster-autoscaler in dual-stack case. #10994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fix CalculateMaxNodesForShoot for cluster-autoscaler in dual-stack case. #10994

merged 2 commits into from
Dec 11, 2024

Conversation

axel7born
Copy link
Contributor

How to categorize this PR?

/area networking
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixes the calculation of the maximum number of nodes for cluster autoscaling for dual-stack shoots.

@gardener-prow gardener-prow bot added area/networking Networking related kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Dec 6, 2024
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 6, 2024
@axel7born axel7born force-pushed the dual-stack-cluster-autoscaler branch from a9d9876 to 13243e1 Compare December 6, 2024 10:33
@axel7born
Copy link
Contributor Author

/cc @DockToFuture @ScheererJ

ScheererJ
ScheererJ reviewed Dec 6, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@rfranzke rfranzke changed the title Fix CalculateMaxNodesForShoot for clusterautoscaler in dual-stack case. Fix CalculateMaxNodesForShoot for cluster-autoscaler in dual-stack case. Dec 9, 2024
ScheererJ
ScheererJ approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 11, 2024

LGTM label has been added.

Git tree hash: d6b189833f3e28bd2003fd5d2b655b9c467a4638

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@gardener-prow gardener-prow bot merged commit 157f7a6 into gardener:master Dec 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

@ary1992 ary1992 Awaiting requested review from ary1992

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

@DockToFuture DockToFuture Awaiting requested review from DockToFuture

Assignees

@ScheererJ ScheererJ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking Networking related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axel7born @ScheererJ