Skip to content

[GEP-28] Add new e2e test skeleton for gardenadm functionality #10977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 16, 2024
Merged

[GEP-28] Add new e2e test skeleton for gardenadm functionality #10977

merged 14 commits into from
Dec 16, 2024

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Dec 4, 2024 •
edited by timebertt
Loading

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:

This PR adds make targets for the dev and e2e test setup for autonomous shoot clusters as well as the e2e test skeleton for gardenadm.

The setup is similar to the kind-based setup for gardener itself. We reuse the kind cluster, some skaffold configuration, and the provider-local machine pod image.

The e2e tests are executed on PRs and periodically on master (see gardener/ci-infra#2827).
In contrast to the existing e2e tests, the new gardenadm tests use ginkgo's ordered containers feature. I.e., there are individual It specs for each step instead of large It specs with multiple By steps.
This improves the test debugging and deflaking experience, as the output (also visualized in testgrid) points to an individual step where the tests failed.

Which issue(s) this PR fixes:
Part of #2906

Special notes for your reviewer:

Release note:

A local setup for trying out, developing, and testing the autonomous shoot cluster functionality of `gardenadm` has been introduced. You can find the documentation [here](https://github.com/gardener/gardener/blob/master/docs/deployment/getting_started_locally_with_gardenadm.md).

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Dec 4, 2024
@rfranzke rfranzke mentioned this pull request Dec 4, 2024
Open
@gardener-prow gardener-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 4, 2024
@rfranzke rfranzke mentioned this pull request Dec 4, 2024
Merged
@timuthy
Copy link
Member

timuthy commented Dec 5, 2024

/assign

@timebertt
Copy link
Member

I added the missing documentation to this PR. It's ready for review now :)

@timebertt timebertt marked this pull request as ready for review December 6, 2024 14:58
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2024
@gardener-prow gardener-prow bot requested review from marc1404 and plkokanov December 6, 2024 14:58
@rfranzke rfranzke force-pushed the e2e-gardenadm branch 2 times, most recently from de32617 to 87006ac Compare December 9, 2024 09:23
@rfranzke
Copy link
Member Author

rfranzke commented Dec 9, 2024

@timebertt Thanks for the docs, I think it looks good (made minimal adjustments). I have fixed a gosec finding for the e2e tests - otherwise, I think the PR is ready to go.
Looking forward to @timuthy's feedback!

@rfranzke rfranzke force-pushed the e2e-gardenadm branch 4 times, most recently from 6dbbcb1 to 3be597b Compare December 9, 2024 16:05
marc1404
marc1404 reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the great documentation along with the test skeleton!
The getting started locally with gardenadm works out-of-the-box on my machine™ :)

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 10, 2024

LGTM label has been added.

Git tree hash: 6f6b80956ae488b9a58f4eec1547b110e23729d6

rfranzke and others added 12 commits December 16, 2024 10:52
@rfranzke @timebertt
Prefactor: Move containerd hosts config to node image
de0901f 
Co-authored-by: Tim Ebert <timebertt@gmail.com>
@rfranzke @timebertt
New Skaffold config for high-touch scenario
17f296b 
Co-authored-by: Tim Ebert <timebertt@gmail.com>
@rfranzke @timebertt
Prefactor: Drop duplicated implementation of pod executor
e1f25c9 
and add it to the `kubernetes.Interface` to simplify usage

Co-authored-by: Tim Ebert <timebertt@gmail.com>
@rfranzke @timebertt
e2e Tests
a2c2e4b 
Co-authored-by: Tim Ebert <timebertt@gmail.com>
@rfranzke @timebertt
Scale up machine pods and add dummy test for gardenadm join
4ec852f 
Co-authored-by: Tim Ebert <timebertt@gmail.com>
@rfranzke @timebertt
Prepare directory structure for medium-touch tests
7ba3a2a 
Co-authored-by: Tim Ebert <timebertt@gmail.com>
@rfranzke @timebertt
Forward output of failing commands
8b4b395 
Co-authored-by: Tim Ebert <timebertt@gmail.com>
@rfranzke @timebertt
e2e Tests for medium-touch case
d976bc0 
Co-authored-by: Tim Ebert <timebertt@gmail.com>
@rfranzke @timebertt
New Skaffold config for medium-touch scenario
cc5badb 
Co-authored-by: Tim Ebert <timebertt@gmail.com>
@rfranzke
Make gosec happy
e8df83d
@rfranzke
Address PR review feedback
80aee8d
@rfranzke
Address PR review feedback
da1c74a
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@gardener-prow gardener-prow bot requested review from timebertt and timuthy December 16, 2024 09:53
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 16, 2024

LGTM label has been added.

Git tree hash: 9758b2b31f6b58df1dd962507ea93b41a6d28d8b

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ, timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ScheererJ,timebertt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot merged commit c0486a3 into gardener:master Dec 16, 2024
18 checks passed
@rfranzke rfranzke deleted the e2e-gardenadm branch December 16, 2024 12:58
@MartinWeindel MartinWeindel mentioned this pull request Jan 10, 2025
Merged
@ialidzhikov ialidzhikov mentioned this pull request Jan 29, 2025
Closed
@timebertt timebertt mentioned this pull request Feb 13, 2025
Closed
@ialidzhikov ialidzhikov mentioned this pull request Mar 19, 2025
Merged
@dimitar-kostadinov dimitar-kostadinov mentioned this pull request Mar 21, 2025
Merged
@ialidzhikov ialidzhikov mentioned this pull request Apr 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt approved these changes

@LucaBernstein LucaBernstein Awaiting requested review from LucaBernstein

@plkokanov plkokanov Awaiting requested review from plkokanov

@marc1404 marc1404 Awaiting requested review from marc1404

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

@timuthy timuthy Awaiting requested review from timuthy

Assignees

@marc1404 marc1404

@ScheererJ ScheererJ

@timuthy timuthy

@timebertt timebertt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfranzke @timuthy @timebertt @ScheererJ @marc1404