Skip to content

[release-v1.107] [GEP-28] Add build-gardenadm script for Concourse CI #10940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2024
Merged

[release-v1.107] [GEP-28] Add build-gardenadm script for Concourse CI #10940

merged 5 commits into from
Nov 28, 2024

Conversation

gardener-ci-robot
Copy link
Contributor

@gardener-ci-robot gardener-ci-robot commented Nov 28, 2024 •
edited
Loading

This is an automated cherry-pick of #10934

/assign rfranzke

NONE

@rfranzke
install.sh: Allow overwriting GO{OS,ARCH} env vars
ad5010e
@rfranzke
Copy install.sh to build.sh
c6a342d 
To run `go build` instead of `go install`
@rfranzke
Add build rule to Makefile
f1af746 
This allows levering the version handling part of the Makefile (similar
to `make install` what is called inside the `Dockerfile`).
@rfranzke
Add build-gardenadm script for Concourse CI
561e081
@rfranzke
Address PR review feedback
992ef4e
@gardener-ci-robot gardener-ci-robot added the kind/enhancement Enhancement, improvement, extension label Nov 28, 2024
@gardener-ci-robot gardener-ci-robot mentioned this pull request Nov 28, 2024
Merged
@gardener-ci-robot gardener-ci-robot added the area/delivery Delivery related label Nov 28, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2024
@rfranzke
Copy link
Member

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 28, 2024

LGTM label has been added.

Git tree hash: c9653fe8f01bbf5baa3a7682b54aea73946cd123

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@rfranzke
Copy link
Member

/override pull-gardener-e2e-kind-ha-multi-zone-release-v1-107

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 28, 2024

@rfranzke: Overrode contexts on behalf of rfranzke: pull-gardener-e2e-kind-ha-multi-zone-release-v1-107

In response to this:

/override pull-gardener-e2e-kind-ha-multi-zone-release-v1-107

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow bot merged commit 54210c3 into gardener:release-v1.107 Nov 28, 2024
17 checks passed
@gardener-ci-robot gardener-ci-robot deleted the cherry-pick-10934-to-release-v1.107 branch November 28, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plkokanov plkokanov Awaiting requested review from plkokanov

@tobschli tobschli Awaiting requested review from tobschli

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/delivery Delivery related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gardener-ci-robot @rfranzke