Skip to content

[GEP-28] Add build-gardenadm script for Concourse CI #10934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2024
Merged

[GEP-28] Add build-gardenadm script for Concourse CI #10934

merged 5 commits into from
Nov 28, 2024

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Nov 27, 2024 •
edited
Loading

How to categorize this PR?

/area delivery
/kind enhancement

What this PR does / why we need it:
Add build-gardenadm script for Concourse CI. The idea is that the head-update and release jobs run this script in order to build the binaries and add them as assets to the respective (draft) releases.

Part of #2906

Special notes for your reviewer:
/cc @ScheererJ @ccwienk @8R0WNI3

Release note:

NONE

@gardener-prow gardener-prow bot added area/delivery Delivery related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2024
@rfranzke rfranzke changed the title Add build-gardenadm script for Concourse CI [GEP-28] Add build-gardenadm script for Concourse CI Nov 27, 2024
@rfranzke rfranzke mentioned this pull request Nov 27, 2024
Open
@ScheererJ
Copy link
Member

/assign

ScheererJ
ScheererJ reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for preparing the binary delivery of gardenadm.

I just have one suggestion.

@rfranzke
install.sh: Allow overwriting GO{OS,ARCH} env vars
b1c4667
@rfranzke
Copy install.sh to build.sh
26ab594 
To run `go build` instead of `go install`
@rfranzke
Add build rule to Makefile
e2fa881 
This allows levering the version handling part of the Makefile (similar
to `make install` what is called inside the `Dockerfile`).
@rfranzke
Add build-gardenadm script for Concourse CI
98a7b48
@rfranzke
Address PR review feedback
5b09e91
@rfranzke rfranzke requested a review from ScheererJ November 28, 2024 08:10
@rfranzke
Copy link
Member Author

The idea is to cherry-pick this PR to the release-v10{7,8,9} branches so that we can adapt the Concourse build pipeline in a straight-forward way (w/o this, the script would only be available on release-v1.110 and we would have to distinguish about this in the pipeline definition).

@rfranzke
Copy link
Member Author

/cherry-pick release-v1.109

@rfranzke
Copy link
Member Author

/cherry-pick release-v1.108

@rfranzke
Copy link
Member Author

/cherry-pick release-v1.107

@gardener-ci-robot
Copy link
Contributor

@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.109 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.109

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot
Copy link
Contributor

@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.108 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.108

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot
Copy link
Contributor

@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.107 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.107

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ScheererJ
ScheererJ reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 28, 2024

LGTM label has been added.

Git tree hash: 778dce77fc07b176520179363dec377742f5379c

@rfranzke
Copy link
Member Author

/approve

@oliver-goetz suggested to tar/zip the binaries before uploading, so we might consider this as a future improvement in case the binary size grows as we progress with the GEP implementation

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@gardener-prow gardener-prow bot merged commit c3cdab0 into gardener:master Nov 28, 2024
18 checks passed
@gardener-ci-robot
Copy link
Contributor

@rfranzke: new pull request created: #10938

In response to this:

/cherry-pick release-v1.109

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot gardener-ci-robot mentioned this pull request Nov 28, 2024
Merged
@gardener-ci-robot
Copy link
Contributor

@rfranzke: new pull request created: #10939

In response to this:

/cherry-pick release-v1.108

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot gardener-ci-robot mentioned this pull request Nov 28, 2024
Merged
@gardener-ci-robot
Copy link
Contributor

@rfranzke: new pull request created: #10940

In response to this:

/cherry-pick release-v1.107

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot gardener-ci-robot mentioned this pull request Nov 28, 2024
Merged
@rfranzke rfranzke deleted the build-gardenadm branch November 28, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ left review comments

@8R0WNI3 8R0WNI3 Awaiting requested review from 8R0WNI3

@ccwienk ccwienk Awaiting requested review from ccwienk

Assignees

@ScheererJ ScheererJ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/delivery Delivery related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfranzke @ScheererJ @gardener-ci-robot