chore(deps): update registry.k8s.io/coredns/coredns docker tag to v1.12.0 #10909

gardener-ci-robot · 2024-11-24T20:05:25Z

This PR contains the following updates:

Package	Update	Change
registry.k8s.io/coredns/coredns	minor	`v1.11.4` -> `v1.12.0`

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

Release note:

The `registry.k8s.io/coredns/coredns` image has been updated to `v1.12.0`.

marc1404

/hold

Requires a change like this one:
2f63ea8 (#10224)

I'll check where Renovate's configuration could be updated to catch both occurrences.

marc1404 · 2024-11-26T11:45:58Z

TODO to check:

gardener/imagevector/containers.yaml

Line 395 in 34b7d92

    
           # TODO(DockToFuture): When updating coredns to v1.12.x check if the NET_BIND_SERVICE capability can be removed.

gardener-ci-robot · 2024-11-26T14:56:30Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

marc1404 · 2024-11-26T15:19:28Z

.github/renovate.json5

@@ -32,6 +32,7 @@
        '^example/.+\\.yaml$',
        '^hack/.+\\.yaml$',
        '^\\.test-defs/.+\\.yaml$',
+        '^charts/.+\\.yaml$',


This includes YAML files in the charts folder for Renovate to update image tags such as this one:
2f63ea8 (#10224)

Regex test:
https://regex101.com/r/dvfQdb/1

/cc @oliver-goetz

You could also remove this line. It was meant to prevent false positives in chart updates. Apparently, it does not prevent anything anyway as there is a typo in the folder name 😅

Fair enough and well spotted :D
Done via 3e48f0a (#10909)

marc1404 · 2024-11-27T09:35:31Z

Unfortunately, the NET_BIND_SERVICE capability introduced with #8945 can not be removed yet.

One of the related issues is still open:
coredns/coredns#6249

As well as a PR (coredns/coredns#6320) that was meant to remove the hardcoded NET_BIND_SERVICE capability inside CoreDNS' Dockerfile again.

I'll try friendly nudging the issue & PR and might try contributing a change as well.

marc1404 · 2024-11-27T10:06:51Z

/unhold

ScheererJ

/lgtm

gardener-prow · 2024-11-27T16:29:47Z

LGTM label has been added.

Git tree hash: 090b5474f7a505bce6510a142ab1d159ac060134

…12.0

…oredns

…d from coredns" This reverts commit ad6d243.

…ERVICE capability

…iew)

marc1404 · 2024-11-28T08:32:25Z

.github/renovate.json5

@@ -389,7 +390,6 @@
    {
      // Ignore paths which most likely create false positives.
      matchFileNames: [
-        'chart/**',


See: #10909 (comment)

oliver-goetz

Thanks 🚀
/lgtm

gardener-prow · 2024-11-28T08:34:43Z

LGTM label has been added.

Git tree hash: 04b21c64bb60f69e95edea71ccb27786003e1ed6

gardener-prow · 2024-11-28T08:34:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [oliver-goetz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gardener-ci-robot added the kind/enhancement Enhancement, improvement, extension label Nov 24, 2024

gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Nov 24, 2024

gardener-prow bot requested review from acumino and ScheererJ November 24, 2024 20:05

gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 24, 2024

marc1404 reviewed Nov 25, 2024

View reviewed changes

gardener-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2024

marc1404 self-assigned this Nov 26, 2024

gardener-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2024

marc1404 reviewed Nov 26, 2024

View reviewed changes

gardener-prow bot requested a review from oliver-goetz November 27, 2024 09:13

gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2024

ScheererJ reviewed Nov 27, 2024

View reviewed changes

gardener-prow bot assigned ScheererJ Nov 27, 2024

gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024

gardener-ci-robot and others added 7 commits November 28, 2024 09:30

chore(deps): update registry.k8s.io/coredns/coredns docker tag to v1.…

031688c

…12.0

chore: Update Docker images through Renovate in charts

1a3ff84

chore: Update provider-local coredns deployment to v1.12.0

ce8ea9f

chore: Test whether NET_BIND_SERVICE capability can be removed from c…

ffec99f

…oredns

Revert "chore: Test whether NET_BIND_SERVICE capability can be remove…

49eb8c5

…d from coredns" This reverts commit ad6d243.

chore: Update comment(s) about checking the removal of the NET_BIND_S…

072eb9b

…ERVICE capability

chore: Remove misspelled match file name from Renovate config (PR rev…

3e48f0a

…iew)

marc1404 force-pushed the renovate/registry.k8s.io-coredns-coredns-1.x branch from 9278efd to 3e48f0a Compare November 28, 2024 08:31

gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024

gardener-prow bot requested review from marc1404 and ScheererJ November 28, 2024 08:31

marc1404 reviewed Nov 28, 2024

View reviewed changes

oliver-goetz approved these changes Nov 28, 2024

View reviewed changes

gardener-prow bot assigned oliver-goetz Nov 28, 2024

gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024

gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024

gardener-prow bot merged commit e151a63 into master Nov 28, 2024
19 checks passed

gardener-prow bot deleted the renovate/registry.k8s.io-coredns-coredns-1.x branch November 28, 2024 13:45

chore(deps): update registry.k8s.io/coredns/coredns docker tag to v1.12.0 #10909

chore(deps): update registry.k8s.io/coredns/coredns docker tag to v1.12.0 #10909

Uh oh!

Conversation

gardener-ci-robot commented Nov 24, 2024

Configuration

Uh oh!

marc1404 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marc1404 commented Nov 26, 2024

Uh oh!

gardener-ci-robot commented Nov 26, 2024

Edited/Blocked Notification

Uh oh!

marc1404 Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

marc1404 Nov 27, 2024

Choose a reason for hiding this comment

Uh oh!

oliver-goetz Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

marc1404 Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

marc1404 commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marc1404 commented Nov 27, 2024

Uh oh!

ScheererJ left a comment

Choose a reason for hiding this comment

Uh oh!

gardener-prow bot commented Nov 27, 2024

Uh oh!

marc1404 Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

oliver-goetz left a comment

Choose a reason for hiding this comment

Uh oh!

gardener-prow bot commented Nov 28, 2024

Uh oh!

gardener-prow bot commented Nov 28, 2024

Uh oh!

Uh oh!

Uh oh!

marc1404 left a comment •

edited

Loading

marc1404 commented Nov 27, 2024 •

edited

Loading