Skip to content

Conversation

oliver-goetz
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:
This PR groups updates of machine-controller-manager in one single PR. Example

Additionally, it runs make generate when MCM is updated, because it might contain API changes.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Nov 22, 2024
@gardener-prow gardener-prow bot requested review from acumino and tobschli November 22, 2024 17:07
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 22, 2024
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks! :)

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
Copy link
Contributor

gardener-prow bot commented Nov 25, 2024

LGTM label has been added.

Git tree hash: b001ed71a40e9121022a033eb0a52c90f8f6a0da

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
@gardener-prow gardener-prow bot requested a review from marc1404 November 25, 2024 08:53
@oliver-goetz oliver-goetz changed the title [renovate] Group machine-controller-manager updates [renovate] Group machine-controller-manager & etcd-druid updates Nov 25, 2024
Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
Copy link
Contributor

gardener-prow bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shafeeqes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

gardener-prow bot commented Nov 25, 2024

LGTM label has been added.

Git tree hash: 8b303f0ee693c88317b5641309ae35441fd4c442

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@gardener-prow gardener-prow bot merged commit 73653e0 into gardener:master Nov 25, 2024
19 checks passed
@oliver-goetz oliver-goetz deleted the enh/renovate-group-mcm branch November 25, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants