Skip to content

[GEP-28] Initial gardenadm skaffolding and introduction of new component #10729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2024
Merged

[GEP-28] Initial gardenadm skaffolding and introduction of new component #10729

merged 5 commits into from
Oct 29, 2024

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area ops-productivity open-source
/kind enhancement

What this PR does / why we need it:
This PR introduces the gardenadm component with its few commands proposed in GEP-28.
The commands are not yet implemented at all, this will follow in subsequent PRs. The goal of this PR is to just prepare the boilerplate and prepare the initial skaffolding.

Which issue(s) this PR fixes:
Part of #2906

Special notes for your reviewer:
/cc @ScheererJ

You can test it like this:

go build -o bin/gardenadm ./cmd/gardenadm
./bin/gardenadm

gardenadm bootstraps and manages autonomous shoot clusters in the Gardener project.

Usage:
  gardenadm [command]

Autonomous Shoot Cluster Bootstrap Commands:
  bootstrap   Bootstrap the infrastructure for an Autonomous Shoot Cluster (networks, machines, etc.)
  init        Bootstrap a first control plane node
  join        Bootstrap further control plane nodes, or bootstrap worker nodes, and join them to the cluster
  token       Manage bootstrap and discovery tokens for gardenadm join

Garden Cluster Interaction Commands:
  connect     Deploy a gardenlet for further cluster management
  discover    Conveniently download Gardener configuration resources from an existing garden cluster

Additional Commands:
  completion  Generate the autocompletion script for the specified shell
  help        Help about any command
  version     Print the client version information

Flags:
  -h, --help   help for gardenadm

Use "gardenadm [command] --help" for more information about a command.

Release note:

NONE

@gardener-prow gardener-prow bot requested a review from ScheererJ October 25, 2024 09:34
@gardener-prow gardener-prow bot added area/ops-productivity Operator productivity related (how to improve operations) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 25, 2024
@gitguardian GitGuardian
Copy link

gitguardian bot commented Oct 25, 2024 •
edited
Loading

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret f40adca pkg/gardenadm/cmd/token/create/options.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@rfranzke rfranzke mentioned this pull request Oct 25, 2024
Open
@Kostov6
Copy link
Contributor

Kostov6 commented Oct 25, 2024

/assign

RadaBDimitrova
RadaBDimitrova reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@RadaBDimitrova RadaBDimitrova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a joint review with @Kostov6
Minor suggestions and questions

@ScheererJ
Copy link
Member

/assign

@rfranzke
Move InitRun function into isolated package
0433edb 
This file has been deliberately moved into its own package since it imports k8s.io/component-base/version/verflag
which automatically registers the `--version` flag as soon as the packages is (transitively) imported.
In order to prevent this from happening accidentally, it's safer to keep it in its own package.
@rfranzke
Boilerplate for new gardenadm binary
f40adca
@rfranzke
Address PR review feedback
aa16a9f
@rfranzke
[PR review feedback] Exit on error
7b8bc2a
ScheererJ
ScheererJ reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the initial gardenadm framework. Looks good already. I have only a few minor nits.

@rfranzke rfranzke requested a review from ScheererJ October 28, 2024 14:37
ScheererJ
ScheererJ approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Oct 28, 2024

LGTM label has been added.

Git tree hash: 07b38cb4142657a88b6d1d095985cebfe9bcde6b

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@shafeeqes
Copy link
Contributor

/retest

@gardener-prow gardener-prow bot merged commit 171a247 into gardener:master Oct 29, 2024
19 checks passed
@rfranzke rfranzke deleted the gardenadm branch November 6, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

@RadaBDimitrova RadaBDimitrova Awaiting requested review from RadaBDimitrova

Assignees

@Kostov6 Kostov6

@ScheererJ ScheererJ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/ops-productivity Operator productivity related (how to improve operations) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfranzke @Kostov6 @ScheererJ @shafeeqes @RadaBDimitrova