Skip to content

Drop support for Shoots with Kubernetes version <= 1.26 #10664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Feb 21, 2025
Merged

Drop support for Shoots with Kubernetes version <= 1.26 #10664

merged 32 commits into from
Feb 21, 2025

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Oct 17, 2024 •
edited
Loading

How to categorize this PR?

/kind cleanup

What this PR does / why we need it:
Apart from the non-version specific changes mentioned in the issue,

  • UnhealthyPodEvictionPolicy in the PDB spec for components is unconditionally set to AlwaysAllow
  • EnableStaticTokenKubeconfig in the Shoot spec is deprecated and the maintenance reconciler is adapted
  • corev1.AnnotationTopologyMode constant is used unconditionally
  • Remove validation related to seccompDefault
  • Adapt validation and doc string related to encryption config.
  • Adapt kubelet config (ProtectKernelDefaults etc.)

Which issue(s) this PR fixes:
Part of #10339

Special notes for your reviewer:
I have not adapted the version usage in tests where the version is independent of the test case. For eg, the workerpool kubernetes version validation (ref). IMO, this is unneeded maintenance work. Similarly in docs as well.

Release note:

⚠️ Gardener does no longer support garden, seed, or shoot clusters with Kubernetes versions <= 1.26. Make sure to upgrade all existing clusters before upgrading to this Gardener version.

The `.spec.kubernetes.enableStaticTokenKubeconfig` field in the Shoot API is deprecated and will be removed in Gardener `v1.120`. Please adapt your Shoot manifests accordingly.

The `.spec.kubernetes.kubeControllerManager.podEvictionTimeout` field in the Shoot API is deprecated since Gardener `v1.63` and will be removed in Gardener `v1.120`. Please adapt your Shoot manifests accordingly.

@gardener-prow gardener-prow bot added kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Oct 17, 2024
@gardener-prow gardener-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 17, 2024
@shafeeqes shafeeqes mentioned this pull request Oct 17, 2024
Closed
29 tasks
@shafeeqes shafeeqes force-pushed the cleanup/k8s-1.26 branch 2 times, most recently from 901ddf5 to a03e806 Compare October 18, 2024 05:04
@shafeeqes shafeeqes mentioned this pull request Oct 18, 2024
Closed
rfranzke
rfranzke reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so good, thanks @shafeeqes for taking the effort of cleaning this up. Very well done 🙇🏻

rfranzke
rfranzke reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Oct 18, 2024

LGTM label has been added.

Git tree hash: 3204db91a4cf97f129cfec19b6d89fb91489c88d

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2024
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@gardener-prow gardener-prow bot requested a review from rfranzke October 18, 2024 10:49
@gardener-prow gardener-prow bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 18, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2024
rfranzke
rfranzke reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Oct 21, 2024

LGTM label has been added.

Git tree hash: 661f49381b16cca39c5e9140fad4b641bfd5f207

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2024
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2024
@gardener-prow gardener-prow bot requested a review from rfranzke October 23, 2024 03:39
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2025
rfranzke
rfranzke reviewed Feb 21, 2025
View reviewed changes
@shafeeqes shafeeqes requested a review from rfranzke February 21, 2025 12:49
rfranzke
rfranzke reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 21, 2025

LGTM label has been added.

Git tree hash: cc8976ed45c210aae738afe3e2e38aebd0bdf4c7

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2025
@oliver-goetz
Copy link
Member

Finally 😅

@shafeeqes
Copy link
Contributor Author

Finally 😅

😭

@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Feb 21, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 21, 2025 •
edited
Loading

@shafeeqes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-apidiff 5c58533 link false /test pull-gardener-apidiff

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gardener-prow gardener-prow bot merged commit 3b181ba into gardener:master Feb 21, 2025
18 of 19 checks passed
@shafeeqes shafeeqes deleted the cleanup/k8s-1.26 branch February 22, 2025 01:36
@AleksandarSavchev AleksandarSavchev mentioned this pull request Mar 24, 2025
Merged
1 task
@shafeeqes shafeeqes mentioned this pull request Jun 10, 2025
Merged
@ialidzhikov ialidzhikov mentioned this pull request Jun 27, 2025
Closed
27 tasks
@RadaBDimitrova RadaBDimitrova mentioned this pull request Jul 18, 2025
Merged
@ialidzhikov ialidzhikov mentioned this pull request Aug 27, 2025
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

@tobschli tobschli Awaiting requested review from tobschli

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shafeeqes @aabond @gardener-ci-robot @oliver-goetz @rfranzke