Support shoot access restriction configurations in CloudProfile, Seed, and Shoot APIs
#10654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
CloudProfile, Seed, and Shoot APIs
CloudProfile, Seed, and Shoot APIs CloudProfile, Seed, and Shoot APIs
|
/assign |
shafeeqes
reviewed
Oct 16, 2024
|
LGTM label has been added. Git tree hash: 05bff3906d67452d8f0cfa44f4394c0c6b85fdea
|
|
/lgtm |
Kostov6
reviewed
Oct 16, 2024
3f7d022 to
b34e337
Compare
b34e337 to
148d998
Compare
148d998 to
654fc40
Compare
|
LGTM label has been added. Git tree hash: 9f5fc42af6cfab4b4238e255965883018f6edb22
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petersutter, rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind api-change
/kind enhancement
What this PR does / why we need it:
This PR introduces dedicated fields to configure access restrictions in the APIs of
CloudProfile,Seed, andShootbased on https://github.com/gardener/dashboard/blob/master/docs/operations/access-restrictions.md#access-restrictions.Currently, Gardener does not know about this feature, and it is solely implement in the Dashboard as well as
gardenctl, which comes with certain limitations, see gardener/dashboard#2120 (comment).Read https://github.com/rfranzke/gardener/blob/access-restrictions/docs/usage/shoot/access_restrictions.md to learn what has been implemented as part of this PR.
Which issue(s) this PR fixes:
Follow-up of #2340
Part of gardener/dashboard#2120
Special notes for your reviewer:
/cc @grolu @petersutter
Release note:
The `CloudProfile`, `Seed`, and `Shoot` APIs are now allowing to configure access restrictions (e.g., to enable "EU access"-only or similar policies). The legacy approach with the `seed.gardener.cloud/eu-access` labels is deprecated and will be removed in a future release. Make sure to adapt to the new APIs. Read all about it [here](https://github.com/gardener/gardener/tree/master/docs/usage/shoot/access_restrictions.md).