-
Notifications
You must be signed in to change notification settings - Fork 526
[GEP-28] Autonomous Shoot Clusters #10536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com> Co-Authored-By: Vedran Lerenc <vlerenc@gmail.com>
/assign |
/assign |
/assign |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the GEP and the clear explanation. Loved reading this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed proposal!
I have some in-line comments and some general questions
- Will the nodes of an autonomous cluster be managed by MCM at some point and how the manually created one will be handled (ignored/deleted)?
- While k8s minor version update is expected to be in-place, is it planned to support OS version update?
- How will be agents (gardenadm, garden-node-agent, gardener-resource-manager, etc.) on the node updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the GEP! A couple of questions and a suggestion from my side
This depends heavily on the scenario (see https://github.com/gardener/gardener/blob/68ccf134a903568bb724f0926d5c3dfa2e470379/docs/proposals/28-autonomous-shoot-clusters.md#scenarios).
It is assumed that this will be tackled as part of #10219 (see https://github.com/gardener/gardener/blob/68ccf134a903568bb724f0926d5c3dfa2e470379/docs/proposals/28-autonomous-shoot-clusters.md#high-touch), but yes, the plan is to be able to do as much as possible also in-place, potentially with a restart of the node if required.
That being said, the update of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice GEP and very interesting concepts to align the current architecture with the autonomous goals 👏
Actually, we would still go (at least for now) with regular rolling updates of the worker or control plane nodes in case they are managed by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice GEP, great work! I love that the reasoning behind all the ideas is explained and easy to understand. Overall, the proposal has a great level of details.
I'm sold on the general approach and I envision that it will fit my team's strategy and help us simplify the management of our initial clusters.
My comments mainly focus on sharpening some of the proposal's details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, GEP thanks 🚀
I have only few remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments.
From my thoughts, there are only open comments left that need to be considered in the implementation. They could be added to #2906 already, but we don't need to add those details to the GEP itself.
Hence, I'd say this PR
/lgtm
😄
LGTM label has been added. Git tree hash: ae0737f0972720936ba58244f5d77929d9b5393f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 5c243010d5a73d95e47ad02a7f77743025e2abf9
|
Thanks for answering my questions. Looking forward to seeing the implementation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScheererJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test all |
How to categorize this PR?
/area documentation
/kind enhancement
What this PR does / why we need it:
This PR proposes GEP-28 for augmenting Gardener's functionality to be able to provision and manage autonomous shoot clusters (i.e., those having dedicated nodes for running the control plane instead of running it in a separate seed cluster).
Which issue(s) this PR fixes:
Part of #2906
Special notes for your reviewer:
cc @ScheererJ @vlerenc
Release note: