Skip to content

Add custom rbac verbs to allow modification of NamespacedCloudProfile.Spec.{Kubernetes,MachineImages} #10485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 12, 2024
Merged

Add custom rbac verbs to allow modification of NamespacedCloudProfile.Spec.{Kubernetes,MachineImages} #10485

merged 11 commits into from
Sep 12, 2024

Conversation

LucaBernstein
Copy link
Member

@LucaBernstein LucaBernstein commented Sep 6, 2024 •
edited
Loading

How to categorize this PR?

/area usability
/area scalability
/kind api-change
/kind enhancement

What this PR does / why we need it:

  • Grant project members access to NamespacedCloudProfiles, with different capabilities depending on their role within the project.
  • Introduce custom rbac verbs modify-spec-kubernetes and modify-spec-machineimages to allow modifications on a NamespacedCloudProfile in the kubernetes and machineImages sections. Typically to be used by operators.
  • Reorder Shoot api response so that cloudProfile and cloudProfileName are placed next to each other. This has a visible impact especially on the dashboard in the Shoot "YAML" page view.

Which issue(s) this PR fixes:
Part of #9504.

Special notes for your reviewer:
/cc @timuthy

Release note:

Allow project users to read `NamespacedCloudProfile`s and for project admins to make adjustments to machine types and volume types.

Introduce custom RBAC verbs to allow for modification of `.spec.{kubernetes,machineImages}` in `NamespacedCloudProfile`s.

@gardener-prow gardener-prow bot requested a review from timuthy September 6, 2024 14:06
@gardener-prow gardener-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Sep 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added area/usability Usability related area/scalability Scalability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 6, 2024
@LucaBernstein LucaBernstein force-pushed the gep-25-namespacedcloudprofiles-pt-3-rbac branch from 3e8f808 to 53a5192 Compare September 6, 2024 14:13
@timuthy
Copy link
Member

timuthy commented Sep 6, 2024

/assign

@LucaBernstein LucaBernstein force-pushed the gep-25-namespacedcloudprofiles-pt-3-rbac branch from 53a5192 to 8ad51ed Compare September 9, 2024 07:33
@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Sep 9, 2024
@LucaBernstein LucaBernstein marked this pull request as ready for review September 9, 2024 07:39
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@LucaBernstein LucaBernstein force-pushed the gep-25-namespacedcloudprofiles-pt-3-rbac branch 2 times, most recently from 769c26d to cd62c39 Compare September 9, 2024 08:05
rfranzke
rfranzke reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document this feature somewhere, please?

@LucaBernstein LucaBernstein force-pushed the gep-25-namespacedcloudprofiles-pt-3-rbac branch from cd62c39 to a0307ec Compare September 9, 2024 10:58
@gardener-prow gardener-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2024
@LucaBernstein
Copy link
Member Author

Can you document this feature somewhere, please?

Thank you for your review.
I improved the variable namings and added some documentation where I saw fit. (ref a0307ec)

@LucaBernstein LucaBernstein force-pushed the gep-25-namespacedcloudprofiles-pt-3-rbac branch from a0307ec to b163ff5 Compare September 10, 2024 08:11
@LucaBernstein LucaBernstein force-pushed the gep-25-namespacedcloudprofiles-pt-3-rbac branch from b163ff5 to c0ac8d4 Compare September 10, 2024 08:15
timuthy
timuthy requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments as discussed.
Very nice PR, thanks for the changes 🙂

timuthy
timuthy requested changes Sep 11, 2024
View reviewed changes
@LucaBernstein LucaBernstein force-pushed the gep-25-namespacedcloudprofiles-pt-3-rbac branch from 6cce4be to 69ce0b2 Compare September 11, 2024 09:06
timuthy
timuthy reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Sep 11, 2024

LGTM label has been added.

Git tree hash: d9d53f07d637f3052f5496e5da3f4714d38993b5

@timuthy timuthy requested a review from rfranzke September 11, 2024 13:31
@LucaBernstein LucaBernstein mentioned this pull request Sep 12, 2024
Open
45 tasks
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
@gardener-prow gardener-prow bot requested a review from timuthy September 12, 2024 09:29
@LucaBernstein LucaBernstein mentioned this pull request Sep 12, 2024
Closed
@LucaBernstein
Harden NamespacedCloudProfile controller integration tests
602b4b7 
It could take some additional time for CloudProfiles to be propagated to the cache and be visible to the controller.
rfranzke
rfranzke reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Sep 12, 2024

LGTM label has been added.

Git tree hash: 129ecf07fa64162e36c566fefff0bc5e691861c8

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@gardener-prow gardener-prow bot merged commit 181337b into gardener:master Sep 12, 2024
19 checks passed
@LucaBernstein LucaBernstein deleted the gep-25-namespacedcloudprofiles-pt-3-rbac branch September 12, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@timuthy timuthy Awaiting requested review from timuthy

Assignees

@rfranzke rfranzke

@timuthy timuthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/scalability Scalability related area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucaBernstein @timuthy @rfranzke