-
Notifications
You must be signed in to change notification settings - Fork 526
Labels
area/auto-scalingAuto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) relatedAuto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) relatedkind/enhancementEnhancement, improvement, extensionEnhancement, improvement, extension
Description
How to categorize this issue?
/area auto-scaling
/kind enhancement
What would you like to be added:
With the introduction of in-place Pod resource updates in VPA 1.4.0, the vpa-updater got instrumented with additional metrics, monitoring which can be very beneficial when evaluating the performance and behaviour of the new updateMode strategy ( i.e. InPlaceOrRecreate
). Much like the vpa-recommender and the vpa-admission-controller, that get their metrics scraped via
vpa-recommender
ServiceMonitor
func (v *vpa) reconcileRecommenderServiceMonitor(serviceMonitor *monitoringv1.ServiceMonitor) { vpa-admission-controller
ServiceMonitorfunc (v *vpa) reconcileAdmissionControllerServiceMonitor(serviceMonitor *monitoringv1.ServiceMonitor) {
the vpa-updater should also be monitored.
Why is this needed:
- To allow better observability of the vpa-updater and the overall health of the
VPA
deployment(s). - To allow a more precise evaluation of the newly introduced
InPlaceOrRecreate
updateMode strategy inVPA
.
dimityrmirchev and plkokanov
Metadata
Metadata
Assignees
Labels
area/auto-scalingAuto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) relatedAuto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) relatedkind/enhancementEnhancement, improvement, extensionEnhancement, improvement, extension