Skip to content

provider-env: support json / yaml output #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 12, 2023
Merged

provider-env: support json / yaml output #298

merged 6 commits into from
May 12, 2023

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
This PR adds the --output flag to the provider-env command

Which issue(s) this PR fixes:
Fixes #287

Special notes for your reviewer:

Release note:

`provider-env`: You can now control the output format using `--output` flag. The data that is typically passed to the templating engine for generating provider-env scripts is instead output in the specified format. Usage: `gardenctl provider-env -oyaml`

@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label May 11, 2023
@petersutter petersutter requested a review from a team as a code owner May 11, 2023 15:26
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 11, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2023
Base automatically changed from enh/move-kubect-and-provider-env to master May 12, 2023 08:39
@petersutter petersutter force-pushed the enh/provider-env-output branch from 9aa741f to 60e4817 Compare May 12, 2023 08:39
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 12, 2023
@petersutter petersutter force-pushed the enh/provider-env-output branch from 60e4817 to df4c8f3 Compare May 12, 2023 08:48
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 12, 2023
holgerkoser
holgerkoser reviewed May 12, 2023
View reviewed changes
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2023
@petersutter petersutter force-pushed the enh/provider-env-output branch from 18191bf to 6a52922 Compare May 12, 2023 10:18
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2023
holgerkoser
holgerkoser approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 12, 2023
@gardener-robot gardener-robot removed the needs/second-opinion Needs second review by someone else label May 12, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2023
@petersutter petersutter merged commit 6f772f3 into master May 12, 2023
@petersutter petersutter deleted the enh/provider-env-output branch May 12, 2023 10:41
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provider-env command should support json / yaml output
6 participants
@petersutter @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot