Skip to content

Use client.authentication.k8s.io/v1 for exec plugin config of Shoot cluster kubeconfig #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2023
Merged

Use client.authentication.k8s.io/v1 for exec plugin config of Shoot cluster kubeconfig #254

merged 1 commit into from
Mar 31, 2023

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
Exec plugin config in kubeconfig is now using API version client.authentication.k8s.io/v1 when kubernetes version of Shoot is >= v1.20.0. For older versions it will fallback to client.authentication.k8s.io/v1beta1

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/hold until gardener/gardenlogin#43 is merged and released

Release note:

Make sure to update `gardenlogin` to `v0.4.0` or higher

Exec plugin config in kubeconfig is now using API version `client.authentication.k8s.io/v1` when kubernetes version of `Shoot` is >= `v1.20.0`. For older versions it will fallback to `client.authentication.k8s.io/v1beta1`

@petersutter petersutter requested a review from a team as a code owner March 14, 2023 18:14
@gardener-robot gardener-robot added reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 14, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 14, 2023
holgerkoser
holgerkoser approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 16, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 16, 2023
grolu
grolu approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@petersutter
Copy link
Member Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Mar 31, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 31, 2023
@petersutter petersutter merged commit 72922d4 into master Mar 31, 2023
@petersutter petersutter deleted the clientauth-v1 branch March 31, 2023 11:56
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 31, 2023
@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu grolu approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petersutter @holgerkoser @grolu @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot