Skip to content

Configurable ports #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

Configurable ports #52

merged 2 commits into from
May 6, 2025

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented May 6, 2025 •
edited
Loading

How to categorize this PR?

/area usability
/kind enhancement

What this PR does / why we need it:

  • druid.gardener.cloud/v1alpha1.Etcd allows to configure etcd's client port, but this is not passed down to etcd-wrapper (it hardcodes to 2379).
  • The server port of etcd-wrapper is hardcoded to 9095 (not configurable), but when it runs in the host network, this can cause conflicts when other instances of it run in parallel.

This PR introduces two new flags (--etcd-client-port and --etcd-wrapper-port) to make these values configurable.

Which issue(s) this PR fixes:
Part of gardener/etcd-druid#1071

Special notes for your reviewer:
/cc @shreyas-s-rao @ishan16696
Follow-up PR in etcd-druid: gardener/etcd-druid#1086

Release note:

The new `--etcd-client-port` flag (default: `2379`) allows to configure the etcd client port.
The new `--etcd-wrapper-port` flag (default: `9095`) allows to configure the etcd-wrapper server port.

@rfranzke rfranzke requested a review from a team as a code owner May 6, 2025 08:47
@gardener-robot gardener-robot added needs/review Needs review area/usability Usability related kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 6, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 6, 2025
@ishan16696
Copy link
Member

/assign

@rfranzke rfranzke mentioned this pull request May 6, 2025
Merged
anveshreddy18
anveshreddy18 requested changes May 6, 2025
View reviewed changes
Copy link

@anveshreddy18 anveshreddy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rfranzke for the PR. Overall looks good to me, except some minor comments. PTAL.

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label May 6, 2025
@anveshreddy18 anveshreddy18 mentioned this pull request May 6, 2025
Closed
@rfranzke rfranzke requested a review from anveshreddy18 May 6, 2025 11:24
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 6, 2025
ishan16696
ishan16696 approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

anveshreddy18
anveshreddy18 approved these changes May 6, 2025
View reviewed changes
Copy link

@anveshreddy18 anveshreddy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishan16696 ishan16696 merged commit 5978b90 into gardener:main May 6, 2025
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 6, 2025
@ishan16696 ishan16696 added this to the v0.5.0 milestone May 6, 2025
@rfranzke rfranzke deleted the ports branch May 6, 2025 13:43
@rfranzke rfranzke mentioned this pull request May 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

@anveshreddy18 anveshreddy18 anveshreddy18 approved these changes

Assignees

@ishan16696 ishan16696

Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rfranzke @ishan16696 @anveshreddy18 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot