Support disabling creation of etcd runtime components #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishan16696
requested changes
Jun 4, 2025
…nciled Etcd resource
unmarshall
requested changes
Jun 6, 2025
|
As discussed in an out-of-band meeting between me, @unmarshall and @ishan16696 , we will allow the annotation to be added/removed during the lifecycle of the Etcd resource and continue having the cleanup logic to correctly handle these transitions in state. Additionally, we also add support for the etcd-component-protection webhook to allow changes on runtime components if the disable-runtime-component-creation annotation is set (in cases where user creates and manages these resource with labels that mimic components actually managed by druid). Changes have been made in 3b71c46. @unmarshall @ishan16696 PTAL. |
unmarshall
requested changes
Jun 25, 2025
|
@unmarshall I've added PDB, client service and peer service to runtime components in 7519be5. PTAL, thanks |
|
/retest |
|
/retest |
unmarshall
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement task
What this PR does / why we need it:
Introduce annotation
druid.gardener.cloud/disable-etcd-runtime-component-creationfor the Etcd resource to instruct druid to not create runtime components for the etcd cluster, such as pods, volumes, member leases and snapshot leases used by the pods to communicate status to druid, and RBAC resources (serviceaccount, role, rolebinding) needed by the etcd member pods to update said leases. This is useful when the operator wants to manage the runtime resources manually or when the runtime resources are not needed, but still requires the correct etcd cluster configuration to be made available.This also disables status checks, since these rely on the existence of said leases and pods to derive etcd cluster status. In the future, we will work on ways for the running members to directly communicate status with druid without the need for a k8s cluster and leases to do so.
Which issue(s) this PR fixes:
Fixes #1106
Special notes for your reviewer:
/cc @rfranzke
/invite @ishan16696
Release note: