Skip to content

Introduce druid.gardener.cloud/disable-member-status-reporting annotation to influence enable{Member,Snapshot}LeaseRenewal flags #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Introduce druid.gardener.cloud/disable-member-status-reporting annotation to influence enable{Member,Snapshot}LeaseRenewal flags #1087

wants to merge 1 commit into from

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented May 6, 2025 •
edited
Loading

How to categorize this PR?

/area usability
/kind enhancement

What this PR does / why we need it:
After #1075, it is possible to configure etcd-backup-restore sidecar with the new --enable-{member,snapshot}-lease-renewal flags. However, they are not exposed via the Etcd API, i.e., it was not possible to configure them. This PR introduces druid.gardener.cloud/disable-member-status-reporting annotation to influence these flags.

Which issue(s) this PR fixes:
Part of #1071
Follow-up of #1075

Special notes for your reviewer:
/cc @shreyas-s-rao @ishan16696

Release note:

It is now possible to disable member and snapshot `Lease` renewals by annotating the `Etcd` resource with `druid.gardener.cloud/disable-member-status-reporting=true`.

@rfranzke rfranzke requested a review from a team as a code owner May 6, 2025 11:31
@gardener-robot gardener-robot added area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 6, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 6, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 6, 2025
@ishan16696
Copy link
Member

/assign

unmarshall
unmarshall reviewed May 9, 2025
View reviewed changes
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label May 9, 2025
@gardener-robot
Copy link

@rfranzke You need rebase this pull request with latest master branch. Please check.

ishan16696
ishan16696 reviewed May 9, 2025
View reviewed changes
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label May 9, 2025
@rfranzke rfranzke changed the title Augment Etcd API with enable{Member,Snapshot}LeaseRenewal fields Introduce druid.gardener.cloud/disable-member-status-reporting annotation to influence enable{Member,Snapshot}LeaseRenewal flags May 9, 2025
@gardener-robot gardener-robot removed the size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) label May 9, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 9, 2025
@rfranzke rfranzke requested review from unmarshall and ishan16696 May 9, 2025 07:30
@rfranzke rfranzke mentioned this pull request May 9, 2025
Open
@ishan16696 ishan16696 removed their assignment May 22, 2025
@shreyas-s-rao shreyas-s-rao self-assigned this May 26, 2025
@shreyas-s-rao shreyas-s-rao mentioned this pull request May 29, 2025
Closed
@shreyas-s-rao
Copy link
Contributor

/close in favour of #1106

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 29, 2025
@shreyas-s-rao shreyas-s-rao removed their assignment May 29, 2025
@rfranzke rfranzke deleted the lease branch May 30, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall Awaiting requested review from unmarshall

@ishan16696 ishan16696 Awaiting requested review from ishan16696

Assignees
No one assigned
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rfranzke @ishan16696 @gardener-robot @shreyas-s-rao @unmarshall @gardener-robot-ci-2 @gardener-robot-ci-3