CRD Validation for Etcd resource using CEL expressions #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shreyas-s14 Thank you for your contribution. |
|
Thank you @Shreyas-s14 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
seshachalam-yv
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Thank you, @Shreyas-s14, for adding the validations for the etcd CR. I've provided a few initial review comments based on my first glance. I will share more detailed feedback after a thorough review.
|
/test pull-etcd-druid-e2e-kind |
5 tasks
* Added `itTestEnv.StartManager()` to start the manager in `setupTestEnvironment()`. * Upgraded teh env-test k8s version to `1.30`. * Changed the timeout to `20s` in `assertReconcileSuspensionEventRecorded` to prevent the test timing out. * Removed an unnecessary `time.Sleep` in `TestValidateSpecReplicas`. * Uncommented previously commented options which caused regressions.
2) added version compatibility docs 3) reduced code reuse in specUpdate_test.go
1) increased value of timeout passed in test/it/helper.go createAndAssertEtcdAndAllManagedResources 2) increased the timeout in test/e2e/suite_test.go to 20 minutes each
Reverted the timeout value in test/it/helper.go which was increased to handle failure of prow jobs
…sion-compatibility-matrix.md
c6a0f93 to
a0c45a7
Compare
unmarshall
requested changes
Feb 27, 2025
seshachalam-yv
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Thank you, @Shreyas-s14, for addressing my review comments.
/lgtm
shreyas-s-rao
approved these changes
Mar 9, 2025
seshachalam-yv
requested changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/area control-plane
/area open-source
/kind enhancement
What this PR does / why we need it:
kubebuilder markers, using a combination of CEL Expressions via thex-validationand thevalidationmarkers.api/core/crdsis changed to now have API methods which takes in a k8s version to provide the appropriate CRD.make deploy-*andmake prepare-helm-charttargets to work with CRDs with and without CEL expressions.Which issue(s) this PR fixes:
Fixes #989
Special notes for your reviewer:
Release note: