Skip to content

Styling tweaks #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025
Merged

Styling tweaks #3855

merged 3 commits into from
Apr 29, 2025

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Apr 20, 2025

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

When tips are not shown, unselecting all elements fades out the tips text (again).

The font for labels and such on macOS is too small: 12pt (user) vs 13pt (system) font size. See https://developer.apple.com/design/human-interface-guidelines/typography#macOS.

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

13pt is the default for labels and such on macOS.
GTK uses 12pt at the moment: the default for text entry fields.
It causes a fade-out effect when all elements are deselected.
@github-actions github-actions bot added the python Pull requests that update Python code label Apr 26, 2025
@danyeaw danyeaw added chore Maintenance related PR and removed python Pull requests that update Python code labels Apr 29, 2025
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw merged commit ddca03d into main Apr 29, 2025
24 of 25 checks passed
@danyeaw danyeaw deleted the styling-tweaks branch April 29, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants